Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add new composer-filename option #261

Merged
merged 6 commits into from
Mar 5, 2025
Merged

✨ Add new composer-filename option #261

merged 6 commits into from
Mar 5, 2025

Conversation

badasukerubin
Copy link
Contributor

@badasukerubin badasukerubin commented Sep 11, 2024

Description

As discussed in #258 .

This adds a new composer-filename option to the action, allowing for adding a custom composer filename, which can be helpful for using composer based on different environments.

See: https://getcomposer.org/doc/03-cli.md#composer

Fixes #258.

Motivation and context

See: #258

How has this been tested?

Both unit tests as well as integration tests are included with the PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@badasukerubin badasukerubin marked this pull request as ready for review September 12, 2024 12:21
@badasukerubin badasukerubin changed the title feat: custom-composer: composer_paths ✨ Add new custom-composer-filename option Sep 12, 2024
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.05%. Comparing base (6a168db) to head (a6d8f18).
Report is 1 commits behind head on v3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #261      +/-   ##
==========================================
- Coverage   97.65%   97.05%   -0.60%     
==========================================
  Files           6        6              
  Lines         128      136       +8     
==========================================
+ Hits          125      132       +7     
- Misses          3        4       +1     
Files with missing lines Coverage Δ
bin/composer_install.sh 100.00% <100.00%> (ø)
bin/composer_paths.sh 97.67% <100.00%> (+0.23%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ramsey ramsey changed the title ✨ Add new custom-composer-filename option ✨ Add new composer-filename option Mar 5, 2025
Copy link
Owner

@ramsey ramsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing, and sorry for taking so long to review this.

I've made a slight change, using composer-filename instead of custom-composer-filename and setting its default value to "composer". I hope this is okay with you.

@ramsey ramsey merged commit 2da6381 into ramsey:v3 Mar 5, 2025
32 checks passed
@derrabus
Copy link

derrabus commented Mar 6, 2025

I believe this change broke workflows that used the COMPOSER env variable previously to achieve the same thing, see #264.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

composer.json based on environment
3 participants