Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release validation #1859

Merged
merged 5 commits into from
Oct 7, 2021

Conversation

galal-hussein
Copy link
Contributor

Proposed Changes

Add release validation script, the script check for the following in order:

  • The release branch: it makes sure that release branch matches the release tag version
  • The kubernetes image tag: it makes sure that image tag matches the release tag version
  • The kubernetes version: it makes sure that kubernetes version env variable matches the release tag version since its used in building both the runtime and windows runtime images as well as the test image
  • The Kube-proxy version: it makes sure that kube proxy chart version matches the release tag version
  • crictl and calico windows binaries: it makes sure that both binaries matches the Linux versions

Types of Changes

CI Feature

Linked Issues

@galal-hussein galal-hussein changed the title Add release validation [WIP] Add release validation Sep 20, 2021
@galal-hussein galal-hussein marked this pull request as ready for review September 21, 2021 20:30
@galal-hussein galal-hussein requested a review from a team as a code owner September 21, 2021 20:30
@galal-hussein galal-hussein changed the title [WIP] Add release validation Add release validation Sep 21, 2021

BUILD_REGEX="build[0-9]+"

info() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we're gonna need a shell package to source these types of things in since they're used in some many placed. No action. Just sayin... :)

@galal-hussein galal-hussein merged commit f944838 into rancher:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants