Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing LanczosLowNoise #290

Merged
merged 13 commits into from
Aug 29, 2024
Merged

fixing LanczosLowNoise #290

merged 13 commits into from
Aug 29, 2024

Conversation

ranocha
Copy link
Owner

@ranocha ranocha commented Aug 29, 2024

This is an extended version of #288 including some required fixes. Thanks a lot to @reula for preparing the initial draft!

Closes #288
Closes #287

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.84%. Comparing base (f49dad4) to head (bbf702e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/periodic_operators.jl 95.83% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   91.80%   91.84%   +0.03%     
==========================================
  Files          36       36              
  Lines        5530     5578      +48     
==========================================
+ Hits         5077     5123      +46     
- Misses        453      455       +2     
Flag Coverage Δ
unittests 91.84% <95.83%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Aug 29, 2024

Coverage Status

coverage: 92.56% (+0.03%) from 92.535%
when pulling bbf702e on reula_lanczos
into f49dad4 on main.

@ranocha ranocha merged commit f4577ac into main Aug 29, 2024
22 checks passed
@ranocha ranocha deleted the reula_lanczos branch August 29, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add (Super) Lanczos low-noise differentiators of Holoborodko
3 participants