Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More boundschecks for scaling by (inverse) mass matrices #311

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

ranocha
Copy link
Owner

@ranocha ranocha commented Dec 11, 2024

CC @JoshuaLampert

Closes #310

Copy link
Contributor

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have two suggestions/questions.

@ranocha ranocha enabled auto-merge (squash) December 11, 2024 18:46
@ranocha ranocha disabled auto-merge December 11, 2024 18:55
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 93.47826% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.85%. Comparing base (00164c7) to head (2d229a2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/filter.jl 33.33% 2 Missing ⚠️
src/general_operators.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   91.83%   91.85%   +0.02%     
==========================================
  Files          35       35              
  Lines        5571     5587      +16     
==========================================
+ Hits         5116     5132      +16     
  Misses        455      455              
Flag Coverage Δ
unittests 91.85% <93.47%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 92.58% (+0.02%) from 92.56%
when pulling 2d229a2 on hr/scale_tests
into 00164c7 on main.

@ranocha ranocha merged commit ee2393d into main Dec 12, 2024
22 checks passed
@ranocha ranocha deleted the hr/scale_tests branch December 12, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boundscheck for scale_by_mass_matrix! doesn't work
3 participants