Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Cover cpplint for ray/src/ray/scheduling #50686

Merged
merged 5 commits into from
Feb 21, 2025
Merged

[core] Cover cpplint for ray/src/ray/scheduling #50686

merged 5 commits into from
Feb 21, 2025

Conversation

400Ping
Copy link
Contributor

@400Ping 400Ping commented Feb 18, 2025 •
edited
Loading

Why are these changes needed?

Ensure all .h and .cc files in src/ray/scheduling comply with cpplint rules.

Related issue number

Closes: #50679

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

dentiny
dentiny reviewed Feb 18, 2025
View reviewed changes
src/ray/raylet/scheduling/cluster_resource_scheduler.cc Outdated

#include "ray/common/grpc_util.h"
#include "ray/common/ray_config.h"

namespace ray {

using namespace ::ray::raylet_scheduling_policy;
using namespace ::ray::raylet_scheduling_policy; // NOLINT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would prefer to avoid using namespace here, but not a big issue, no need to change.

dentiny
dentiny approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@dentiny dentiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much!

@dentiny
Copy link
Contributor

dentiny commented Feb 18, 2025

Just one comment, coul you please update config file also?

ray/.pre-commit-config.yaml

Line 48 in 543bc11

files: ^src/ray/(util|raylet_client)/.*\.(h|cc)$

@dentiny
Copy link
Contributor

dentiny commented Feb 18, 2025

You need to run ./ci/lint/lint.sh clang_format; this is really unfortunate because we're not use the format linter on precommit hook and CI

@jcotant1 jcotant1 added the core Issues that should be addressed in Ray Core label Feb 19, 2025
@400Ping
Copy link
Contributor Author

400Ping commented Feb 19, 2025

I just run ./ci/lint/lint.sh clang_format a minute ago and it didn't change anything

@dentiny
Copy link
Contributor

dentiny commented Feb 19, 2025

I just run ./ci/lint/lint.sh clang_format a minute ago and it didn't change anything

It doesn't change code, just reports improper usage

@dentiny dentiny added the go add ONLY when ready to merge, run all tests label Feb 19, 2025
@400Ping
[core] Cover cpplint for ray/src/ray/scheduling
0b83f12 
Signed-off-by: 400Ping <43886578+400Ping@users.noreply.github.com>
@400Ping
[chore] Update config file
3eaca2d 
Signed-off-by: 400Ping <43886578+400Ping@users.noreply.github.com>
@400Ping
[chore] format the code
1566b22 
Signed-off-by: 400Ping <43886578+400Ping@users.noreply.github.com>
@400Ping
[chore] add macos and linux
993f7c6 
Signed-off-by: 400Ping <43886578+400Ping@users.noreply.github.com>
@400Ping 400Ping force-pushed the core/cover-cpplint-scheduling branch 2 times, most recently from c661f6d to 993f7c6 Compare February 20, 2025 13:44
@400Ping
[chore] fix lint
f44e83b 
Signed-off-by: 400Ping <43886578+400Ping@users.noreply.github.com>
@dentiny
Copy link
Contributor

dentiny commented Feb 21, 2025

@jjyao / @edoakes / @aslonnie could you please help merge this PR? Thanks!

@edoakes edoakes merged commit 2cdffff into ray-project:master Feb 21, 2025
5 checks passed
@jjyao jjyao mentioned this pull request Feb 21, 2025
Merged
8 tasks
kevin85421 pushed a commit to kevin85421/ray that referenced this pull request Feb 28, 2025
@400Ping @kevin85421
[core] Cover cpplint for ray/src/ray/scheduling (ray-project#50686)
212b321 
Ensure all `.h` and `.cc` files in `src/ray/scheduling` comply with
cpplint rules.

Closes: ray-project#50679 

---------

Signed-off-by: 400Ping <43886578+400Ping@users.noreply.github.com>
Signed-off-by: kaihsun <kaihsun@anyscale.com>
xsuler pushed a commit to antgroup/ant-ray that referenced this pull request Mar 4, 2025
@400Ping @xsuler
[core] Cover cpplint for ray/src/ray/scheduling (ray-project#50686)
3899ead 
Ensure all `.h` and `.cc` files in `src/ray/scheduling` comply with
cpplint rules.

Closes: ray-project#50679 

---------

Signed-off-by: 400Ping <43886578+400Ping@users.noreply.github.com>
xsuler pushed a commit to antgroup/ant-ray that referenced this pull request Mar 4, 2025
@400Ping @xsuler
[core] Cover cpplint for ray/src/ray/scheduling (ray-project#50686)
52f4030 
Ensure all `.h` and `.cc` files in `src/ray/scheduling` comply with
cpplint rules.

Closes: ray-project#50679 

---------

Signed-off-by: 400Ping <43886578+400Ping@users.noreply.github.com>
park12sj pushed a commit to park12sj/ray that referenced this pull request Mar 18, 2025
@400Ping @park12sj
[core] Cover cpplint for ray/src/ray/scheduling (ray-project#50686)
13f7433 
Ensure all `.h` and `.cc` files in `src/ray/scheduling` comply with
cpplint rules.

Closes: ray-project#50679 

---------

Signed-off-by: 400Ping <43886578+400Ping@users.noreply.github.com>
jaychia pushed a commit to jaychia/ray that referenced this pull request Mar 19, 2025
@400Ping @jaychia
[core] Cover cpplint for ray/src/ray/scheduling (ray-project#50686)
d32bcd6 
Ensure all `.h` and `.cc` files in `src/ray/scheduling` comply with
cpplint rules.

Closes: ray-project#50679

---------

Signed-off-by: 400Ping <43886578+400Ping@users.noreply.github.com>
Signed-off-by: Jay Chia <17691182+jaychia@users.noreply.github.com>
jaychia pushed a commit to jaychia/ray that referenced this pull request Mar 19, 2025
@400Ping @jaychia
[core] Cover cpplint for ray/src/ray/scheduling (ray-project#50686)
dd72ae0 
Ensure all `.h` and `.cc` files in `src/ray/scheduling` comply with
cpplint rules.

Closes: ray-project#50679

---------

Signed-off-by: 400Ping <43886578+400Ping@users.noreply.github.com>
Signed-off-by: Jay Chia <17691182+jaychia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dentiny dentiny dentiny approved these changes

Assignees
No one assigned
Labels
core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[core] Cover cpplint for ray/src/ray/scheduling
4 participants
@400Ping @dentiny @edoakes @jcotant1