-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Expo config plugin #317
Merged
safaiyeh
merged 16 commits into
react-native-voice:master
from
EvanBacon:@evanbacon/add-config-plugin
Jun 2, 2021
Merged
Added Expo config plugin #317
safaiyeh
merged 16 commits into
react-native-voice:master
from
EvanBacon:@evanbacon/add-config-plugin
Jun 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
commented
May 17, 2021
safaiyeh
pushed a commit
that referenced
this pull request
Jun 2, 2021
# [3.2.0](v3.1.5...v3.2.0) (2021-06-02) ### Features * **Expo:** Added Expo config plugin ([#317](#317)) ([057e06d](057e06d))
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
roberto-devp
added a commit
to roberto-devp/voice
that referenced
this pull request
Sep 26, 2024
# [3.2.0](react-native-voice/voice@v3.1.5...v3.2.0) (2021-06-02) ### Features * **Expo:** Added Expo config plugin ([#317](react-native-voice/voice#317)) ([057e06d](react-native-voice/voice@057e06d))
basukiatpassio
pushed a commit
to Passiolife/voice
that referenced
this pull request
Oct 25, 2024
This reverts commit 057e06d.
basukiatpassio
added a commit
to Passiolife/voice
that referenced
this pull request
Oct 25, 2024
Revert "feat(Expo): Added Expo config plugin (react-native-voice#317)"
oleksiy271
pushed a commit
to oleksiy271/voice-recognition
that referenced
this pull request
Oct 31, 2024
# [3.2.0](react-native-voice/voice@v3.1.5...v3.2.0) (2021-06-02) ### Features * **Expo:** Added Expo config plugin ([#317](react-native-voice/voice#317)) ([057e06d](react-native-voice/voice@057e06d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
With Expo SDK 41 we've rolled out an interface called config plugins which lets users add native modules that aren't in the Expo Go app to their native cloud builds and locally when prebuilding.
This is a highly requested package so I've created the plugin personally.
We’re still working on improving the development experience for config plugins and custom managed workflow, feel free to add any feedback. People won’t be able to use this in an Expo-Go-like-app until we release “Expo Development Client” (more info).
How
/plugin
folder and anapp.plugin.js
as the main entry point to the plugin. Plugins must run in at node LTS environments (currently that means 12 and greater), so a customtsconfig.json
is used for transpilation.tsc --build plugin
(yarn build:plugin
).Test Plan
npm pack
in the packageyarn add @react-native-voice/voice@../voice/react-native-voice-3.1.5.tgz
@react-native-voice/voice
to the plugins array and build the native app locally withexpo prebuild
andyarn ios
,yarn android
. We plan to further automate these steps withexpo install
andexpo run
commands.Modified some values and in the config plugin and updated with
expo prebuild
andyarn ios
,yarn android
.