Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated minimum boost version required to 1.66.0. #403

Merged
merged 2 commits into from
Sep 10, 2019

Conversation

redboltz
Copy link
Owner

No description provided.

@jseela
Copy link

jseela commented Sep 10, 2019

Oh, so this is where my compiler issues are coming from.
The CMakeLists.txt should probably reflect this, too.

#405

@redboltz
Copy link
Owner Author

redboltz commented Sep 10, 2019

Do you mean
https://github.com/redboltz/mqtt_cpp/blob/master/CMakeLists.txt#L99-L110 ?

If it does, I should update from 1.59.0 to 1.66.0.
In addition, I noticed that since 1.66.0, beast is a part of boost. So I don't need to contain beast as the sub-module.

@jseela
Copy link

jseela commented Sep 10, 2019

That is exactly what I meant.
And you are right, the additional checks for beast should not be necessary. I updated my pull request for that.

@redboltz
Copy link
Owner Author

Thanks. I will update the PR soon.

Since Boost 1.66.0, Beast is a part of Boost.
So I removed Beast git submodule.
@jseela
Copy link

jseela commented Sep 10, 2019

thank you, too

@codecov-io
Copy link

Codecov Report

Merging #403 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #403   +/-   ##
=======================================
  Coverage   85.58%   85.58%           
=======================================
  Files          40       40           
  Lines        6298     6298           
=======================================
  Hits         5390     5390           
  Misses        908      908

@redboltz redboltz merged commit 71da3d7 into master Sep 10, 2019
@redboltz redboltz deleted the update_minimum_boost_required branch September 10, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants