Implemented #471. #472
Merged
Implemented #471. #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added get_context(). Marked as deperecated wrapper functions for asio::ssl::context.
jonesmz
reviewed
Oct 1, 2019
example/tls_ws_both.cpp
Outdated
| @@ -365,7 +365,7 @@ int main(int argc, char** argv) { | |||
| std::uint16_t pid_sub2; | |||
|
|
|||
| auto c = MQTT_NS::make_tls_sync_client_ws(ioc, "localhost", port); | |||
| c->set_ca_cert_file(base + "cacert.pem"); | |||
| c->get_context().load_verify_file(base + "cacert.pem"); | |||
There was a problem hiding this comment.
I recommend
get_ssl_context()
So that it does not get confused with boost::asio::io_context()
There was a problem hiding this comment.
Indeed. I will update it.
P.S. I personally don't like the word ssl but like tls. But keeping asio manner is better for that.
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
========================================
Coverage ? 84.9%
========================================
Files ? 41
Lines ? 6273
Branches ? 0
========================================
Hits ? 5326
Misses ? 947
Partials ? 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added get_context().
Marked as deperecated wrapper functions for asio::ssl::context.