Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quarkus Template #6

Merged
merged 3 commits into from
Mar 4, 2025
Merged

Quarkus Template #6

merged 3 commits into from
Mar 4, 2025

Conversation

maysunfaisal
Copy link
Contributor

@maysunfaisal maysunfaisal commented Mar 3, 2025 •
edited
Loading

  • Quarkus Template adapted from https://github.com/containers/ai-lab-recipes/tree/main/recipes/natural_language_processing/chatbot-java-quarkus
  • This is a direct dump after generating the Template in the main repo, so the Template will defer from the experimental Template
  • No vLLM server, seems like we need to debug the Quarkus Langchain framework, probably need to set quarkus.langchain4j.openai.chat-model.model-name property
  • No RHOAI set up because the DSP image that is being used by all our current existing templates do not have mvn and java installed and I do not want to disrupt the existing templates to add in these utils
  • If and when there is a need to promote this to the main template repo, we can investigate the options 3 and 4 above.

@maysunfaisal
Port over quarkus template from https://github.com/maysunfaisal/ai-la…
4bc6665 
…b-template/tree/quarkus-1/templates/chatbot-java-quarkus

Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
@maysunfaisal
rm vLLM & RHOAI
a669fce 
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
@maysunfaisal maysunfaisal requested a review from Jdubrick March 3, 2025 23:00
Jdubrick
Jdubrick reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment then lgtm :)

@maysunfaisal @Jdubrick
Update scripts/envs/chatbot-java-quarkus
4191b1d 
Co-authored-by: Jordan Dubrick <jdubrick@redhat.com>
@maysunfaisal maysunfaisal requested a review from Jdubrick March 4, 2025 15:57
Jdubrick
Jdubrick approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, are you able to edit the pr title to fix the typo so the merge commit is good?

@maysunfaisal maysunfaisal changed the title Quakus Template Quarkus Template Mar 4, 2025
@maysunfaisal
Copy link
Contributor Author

@Jdubrick lol, sounded like Donald Duck writing. Corrected.

@maysunfaisal maysunfaisal merged commit 83571b1 into redhat-ai-dev:main Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jdubrick Jdubrick Jdubrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maysunfaisal @Jdubrick