fixing other stateful queries issue #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@slorello89 The commit looks good. Can you drop 0.2.4 to test? |
|
@shacharPash @slorello89 Are we able to push this out to nuget real quick? |
|
@VagyokC4 - can you build it from source to check to make sure it totally solves the problem for you? I'm at a conference this week so a bit OOP :) |
@slorello89 Hmmm... so it's working, but it's not. I'm trying to reduce down to a repeatable test... but the initial bug is gone, as I get my data back, however the connection is now dead and all future queried timeout. Any ideas? I'll keep testing and update as I know more. UPDATE1: Maybe it has something to do with the ToListAsync enumerating the collection that is having an issue. Looks like we bomb out after getting 10k results? Here is the offending query var redisCollection = redisConnectionProvider.RedisCollection<MailboxSubjectRecord>();
await redisCollection.Where(x => x.Owners.Contains("IMailbox:01GDXYE6P8GVJ5BHRKR0971GMZ")).ToListAsync().Dump();Here are the results from Monitor |
|
@slorello89 Ok, We can close this issue out, as the fix appears to be working. I will open a new issue as the issue I am seeing I can reproduce in older versions (0.2.1) so this is a completely different / new issue. |
|
@VagyokC4 - that issue you are describing is an older issue with RediSearch (not redis-om-dotnet), where the client was freezing when you went over 10k search results, that issue SHOULD be resolved already. |
|
@VagyokC4 opened a separate issue and confirmed that his 10K search result issue was fixed in a forthcoming version of redis-stack (only applies to RC-7 I think?) |
Yes. By tracking the build numbers, it should have been resolved in 7-RC1, but I can confirm it's resolved in 7-RC2. |
banker
approved these changes
Oct 3, 2022
|
Is there anything blocking this from being released? |
|
Waiting on approvals @rpf3 - ping @shacharPash @chayim |
shacharPash
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #205, adding better exception handling for folks who try enumerating the same redis collection twice. @VagyokC4 - can you check this to make sure this fixes your issue :)