Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Basic Matching Queries Example #228

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Add Basic Matching Queries Example #228

merged 3 commits into from
Oct 7, 2022

Conversation

berviantoleo
Copy link
Contributor

@berviantoleo berviantoleo commented Oct 6, 2022 •
edited
Loading

Closes #219

Discord handle: bervianto.leo#3385

@rtynski
Copy link

rtynski commented Oct 7, 2022 •
edited
Loading

Change Directory name to PascalCase (helpers -> Helpers, models -> Models).
Add new lines at the end of file.

@berviantoleo
Copy link
Contributor Author

Change Directory name to PascalCase (helpers -> Helpers, models -> Models). Add new lines at the end of file.

Thank you for your review. I've updated the PR.

@SuzeShardlow
Copy link

Hi @berviantoleo, thanks for your PR! @slorello89 will be the reviewer.

slorello89
slorello89 approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@slorello89 slorello89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for the contribution @berviantoleo - happy 🎃 hacktoberfest! 🎃

@slorello89 slorello89 merged commit 2e59a04 into redis:main Oct 7, 2022
@berviantoleo
Copy link
Contributor Author

LGTM 👍 Thanks for the contribution @berviantoleo - happy 🎃 hacktoberfest! 🎃

Thank you. 🙂

@SuzeShardlow
Copy link

Closes #219

Discord handle: bervianto.leo#3385

Thanks @berviantoleo, I've given you the Hacktoberfest 2022 role in our Discord server :)

@berviantoleo
Copy link
Contributor Author

Closes #219
Discord handle: bervianto.leo#3385

Thanks @berviantoleo, I've given you the Hacktoberfest 2022 role in our Discord server :)

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorello89 slorello89 slorello89 approved these changes

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hacktoberfest Examples: Basic Matching Queries (strings, numerics, enums, booleans)
4 participants
@berviantoleo @rtynski @SuzeShardlow @slorello89