Quering string array example added #issue 221 #231
Conversation
|
Proposal:
|
|
Closes #221 when merged. |
There was a problem hiding this comment.
Looking pretty good @ramin-guliyev - just a couple of minor items and then I think we're good to go!
|
|
||
| public override string ToString() | ||
| { | ||
| return string.Join(" ", Skills.Skip(0)); |
There was a problem hiding this comment.
calling skip with 0 is inert I think - so I'd say remove the Skip here.
| Console.WriteLine(item.ToString()); | ||
| } | ||
|
|
||
| Console.ReadKey(); |
There was a problem hiding this comment.
This is just personal preference, but I'd say remove the ReadKey at the end here and just let the program terminate when it's done.
|
@slorello89 I have done it. Please review again and merge :) |
There was a problem hiding this comment.
LGTM 👍 thanks for your contribution @ramin-guliyev happy 🎃 hacktoberfest 🎃 (will merge when CI is done)
|
@ramin-guliyev thanks for your PR! If you are a member of our Discord server (https://discord.gg/redis), please let us know your handle so we can give you the |
No description provided.