Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix absolute & component folder imports in Storybook config folder #11746

Merged
merged 9 commits into from
Dec 8, 2024
Merged

Fix absolute & component folder imports in Storybook config folder #11746

merged 9 commits into from
Dec 8, 2024

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Dec 5, 2024 •
edited
Loading

Resolves #11741. Thanks @irg1008 for pointing out the obvious fix.

This should have been updated in the move from webpack to vite, as storybook config files were moved from web/config to web/.storybook then.

This completes the update.

@Philzen Philzen marked this pull request as ready for review December 5, 2024 11:01
@Philzen
Copy link
Contributor Author

Philzen commented Dec 5, 2024

This should ideally be part of the next v8 patch release, as this is the version that introduced this change. Is main the right branch for that or should it be next?

Also i'd suggest to amend the upgrade guide for a smooth transition: https://redwoodjs.com/upgrade/v8#storybook-using-vite

@Tobbe
Copy link
Member

Tobbe commented Dec 5, 2024

Is main the right branch for that or should it be next

main is correct. Our release tooling will cherry-pick the commit over to next when I prep the next patch release

@Tobbe Tobbe added the release:fix This PR is a fix label Dec 5, 2024
@Tobbe Tobbe added this to the next-release-patch milestone Dec 5, 2024
@Tobbe
Copy link
Member

Tobbe commented Dec 5, 2024

Also i'd suggest to amend the upgrade guide for a smooth transition: redwoodjs.com/upgrade/v8#storybook-using-vite

Done! https://redwoodjs.com/upgrade/v8#update-tsconfigjsconfig-for-storybook

@Tobbe
Copy link
Member

Tobbe commented Dec 6, 2024

Looks like the test project fixture CI failure is valid. Do you mind also trying to fix that?

@Philzen
Copy link
Contributor Author

Philzen commented Dec 6, 2024

Looks like the test project fixture CI failure is valid. Do you mind also trying to fix that?

Done. 🫡

@Tobbe Tobbe enabled auto-merge (squash) December 8, 2024 06:44
@Tobbe Tobbe merged commit ec9da01 into redwoodjs:main Dec 8, 2024
48 of 49 checks passed
@Philzen Philzen deleted the patch-26 branch December 8, 2024 08:42
Tobbe added a commit that referenced this pull request Jan 16, 2025
@Philzen @Tobbe
Fix absolute & component folder imports in Storybook config folder (#…
9308917 
…11746)

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
@Tobbe Tobbe modified the milestones: next-release-patch, v8.4.3 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobbe Tobbe Tobbe left review comments

@irg1008 irg1008 irg1008 left review comments

Assignees
No one assigned
Labels
release:fix This PR is a fix
Projects
None yet
Milestone
v8.4.3
3 participants
@Philzen @Tobbe @irg1008