Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Git-1) use tmpdir for feedstocks instead of static directory #2872

Merged
merged 14 commits into from
Aug 21, 2024

Conversation

ytausch
Copy link
Contributor

@ytausch ytausch commented Jul 28, 2024

This is first step of #2812.

  • Pydantic model updated or no update needed

@ytausch ytausch force-pushed the continue-git-backend-part-1 branch from 76d3cb8 to 0b3f203 Compare July 28, 2024 12:03
Copy link

codecov bot commented Jul 28, 2024

Codecov Report

Attention: Patch coverage is 91.93548% with 10 lines in your changes missing coverage. Please review.

Project coverage is 77.49%. Comparing base (90a1db8) to head (c9091c9).
Report is 15 commits behind head on master.

Files Patch % Lines
conda_forge_tick/auto_tick.py 50.00% 6 Missing ⚠️
conda_forge_tick/git_utils.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2872      +/-   ##
==========================================
+ Coverage   77.07%   77.49%   +0.41%     
==========================================
  Files         112      115       +3     
  Lines       12053    12215     +162     
==========================================
+ Hits         9290     9466     +176     
+ Misses       2763     2749      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytausch
Copy link
Contributor Author

ytausch commented Jul 28, 2024

@beckermr ready for review

@beckermr
Copy link
Contributor

Cool. I'm away for the next few days so it will likely be a bit.

@beckermr beckermr self-assigned this Jul 28, 2024
@ytausch ytausch changed the title use tmpdir for feedstocks instead of static directory (Git-1) use tmpdir for feedstocks instead of static directory Jul 28, 2024
@beckermr
Copy link
Contributor

pre-commit.ci autofix

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments / requests / questions. Also, in general I was in the process of removing the context module and its associated dataclasses. They had carried sensitive state in the past and needing them made it a pain to debug the bot. This PR adds more things. If we want to keep them, it might be useful to add factory functions to make a context given some simple data (e.g., the feedstock name).

@ytausch
Copy link
Contributor Author

ytausch commented Aug 13, 2024

Also, in general I was in the process of removing the context module and its associated dataclasses. They had carried sensitive state in the past and needing them made it a pain to debug the bot.

Are you referring to the attrs field? Because the default_branch and feedstock_name should not make so much trouble. Would be helpful to see what exactly is making the trouble. I planned to extend the functionality in further PRs, e.g. to access the automerge feedstock attribute directly as an attribute of the context: See here

This PR adds more things. If we want to keep them, it might be useful to add factory functions to make a context given some simple data (e.g., the feedstock name).

I think I don't really get it. What for? So that setting attrs is not needed anymore?

@ytausch ytausch requested a review from beckermr August 13, 2024 09:53
@beckermr
Copy link
Contributor

Yeah it was setting the attrs field which is a pain, but also I don't like having more than one effective api for things related to the feedstocks. Then, for example, we get code that looks up the automerge attribute either directly from attrs or from this new attribute on the context. It's confusing to have both.

@ytausch
Copy link
Contributor Author

ytausch commented Aug 13, 2024

Understood. But let's get this though nonetheless then? In my imagination, the FeedstockContext serves as kind of a proxy between attrs and the individual attributes accessed in the code - and I have pursued this rather consequently in my changes I think.

Open to refactor this further in separate PRs of course.

@ytausch
Copy link
Contributor Author

ytausch commented Aug 21, 2024

What is wrong with the pre-commit CI integration? It shows a timeout for some reason

@beckermr
Copy link
Contributor

Idk. Maybe try and retrigger with an empty commit.

@beckermr
Copy link
Contributor

I'm seeing this in other repos though.

@ytausch
Copy link
Contributor Author

ytausch commented Aug 21, 2024

It also happened in previous commits here - maybe it is an upstream issue?

@beckermr beckermr enabled auto-merge August 21, 2024 15:22
@beckermr beckermr disabled auto-merge August 21, 2024 15:23
@beckermr beckermr enabled auto-merge August 21, 2024 15:23
@beckermr beckermr added this pull request to the merge queue Aug 21, 2024
Merged via the queue into regro:master with commit ddbdff0 Aug 21, 2024
8 checks passed
@ytausch ytausch deleted the continue-git-backend-part-1 branch August 22, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants