Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not lowercase caip_10 adresses #59

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

Elyniss
Copy link
Contributor

@Elyniss Elyniss commented Feb 9, 2024

Description

When converging Keys Server to this module we overlooked difference in this function

Resolves # (issue)

How Has This Been Tested?

Was tested previously. Caused regression

We need to make sure if Notify Server doesn't depend on it

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 🙏 🙏

@chris13524 chris13524 merged commit 6a24d5f into main Feb 9, 2024
8 checks passed
@chris13524 chris13524 deleted the fix/caip_10_address_translation branch February 9, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants