Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IndexColumnDescriptor members private #9070

Merged
merged 4 commits into from
Feb 19, 2025
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 18, 2025

Related

What

A few steps on the road to unifying timelines and RowId

TODO

  • dataplatform PR

@emilk emilk added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md 🔩 data model Sorbet labels Feb 18, 2025
Copy link

github-actions bot commented Feb 18, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
94bd1f2 https://rerun.io/viewer/pr/9070 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk force-pushed the emilk/encapsultate-index-descr branch from 38971a0 to d0e8dcb Compare February 19, 2025 08:19
@emilk emilk force-pushed the emilk/encapsultate-index-descr branch from 9550364 to 94bd1f2 Compare February 19, 2025 10:30
@emilk emilk marked this pull request as ready for review February 19, 2025 11:57
@emilk emilk merged commit 920de91 into main Feb 19, 2025
35 of 37 checks passed
@emilk emilk deleted the emilk/encapsultate-index-descr branch February 19, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 data model Sorbet exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant