Correct truncation of AnyValues when using strings or bytes #9269
+75
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsaucer
added
🪳 bug
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13819185648 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
Closes #8781
What
This PR adjusts the way we process AnyValues. WIthout this change we have cases where numpy is setting data types to have fixed length based on the first value it receives. This ends up truncating the data.
Additionally, we cannot simply call
pa.array()because types like strings and bytes are iterable and will get turned into an array of characters or bytes, respectively.This PR attempts three passes at converting values
pa.array()directly, but with a special case to ignore string and bytesAdded unit test to capture failure mode in attached issue.