-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layered configuration with serde and figment #233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR @slinkydeveloper. The changes look good to me. +1 for merging.
A follow-up question I have is whether there is a way to automatically collect the configuration options and generate a list for documentation purposes. Ideally, we could also generate the corresponding env variable names for the different options.
Ideally, we get rid of figment for that and directly build a macro ourselves to both generate a parser (also fixing the |
Sounds like an interesting follow-up idea. |
257ab3f
to
753dab2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1 for merging.
Fix #53. Check #53 (comment) for more info about the behaviour.