Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layered configuration with serde and figment #233

Merged
merged 6 commits into from
Mar 31, 2023

Conversation

slinkydeveloper
Copy link
Contributor

Fix #53. Check #53 (comment) for more info about the behaviour.

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @slinkydeveloper. The changes look good to me. +1 for merging.

A follow-up question I have is whether there is a way to automatically collect the configuration options and generate a list for documentation purposes. Ideally, we could also generate the corresponding env variable names for the different options.

@slinkydeveloper
Copy link
Contributor Author

A follow-up question I have is whether there is a way to automatically collect the configuration options and generate a list for documentation purposes. Ideally, we could also generate the corresponding env variable names for the different options.

Ideally, we get rid of figment for that and directly build a macro ourselves to both generate a parser (also fixing the __ issue) and generate docs.

@tillrohrmann
Copy link
Contributor

A follow-up question I have is whether there is a way to automatically collect the configuration options and generate a list for documentation purposes. Ideally, we could also generate the corresponding env variable names for the different options.

Ideally, we get rid of figment for that and directly build a macro ourselves to both generate a parser (also fixing the __ issue) and generate docs.

Sounds like an interesting follow-up idea.

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging.

@slinkydeveloper slinkydeveloper merged commit 49c6022 into restatedev:main Mar 31, 2023
@slinkydeveloper slinkydeveloper deleted the issues/53 branch March 31, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flexible configuration
2 participants