S/fixes and suggestions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought the new default was main? Or is that how they have their repo setup? |
That's how the source repo was configured https://github.com/muenzpraeger/eslint-plugin-inclusive-language/branches |
ebenoist
reviewed
Jan 20, 2021
lib/rules/use-inclusive-words.js
Outdated
| const RULE_CATEGORY = 'Language'; | ||
| const RULE_DESCRIPTION = 'highlights where non-inclusive language is used'; | ||
| // eslint-disable-next-line no-unused-vars | ||
| const SUGGESTION_MESSAGE = "Replace word '{{word}}'' with '{{suggestion}}.'"; // Currently not in use | ||
| const SUGGESTION_MESSAGE = "Replace word '{{word}}' with '{{suggestion}}.'"; // Currently not in use |
ebenoist
reviewed
Jan 20, 2021
| suggestion: result[0].suggestion | ||
| }; | ||
| const { word, explanation } = result; | ||
| // backwards-compatibility with singular suggestions |
ebenoist
reviewed
Jan 20, 2021
| @@ -117,6 +142,9 @@ module.exports = { | |||
| Identifier(node) { | |||
| validateIfInclusive(context, node, node.name); | |||
| }, | |||
| JSXIdentifier(node) { | |||
|
Nice work! |
ebenoist
approved these changes
Jan 20, 2021
stevenweber
force-pushed
the
s/fixes-and-suggestions
branch
from
7ae6b35 to
a98c1c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.