Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip switches without state labels #640

Closed
wants to merge 5 commits into from
Closed

Skip switches without state labels #640

wants to merge 5 commits into from

Conversation

groverlynn
Copy link
Contributor

@groverlynn groverlynn commented Apr 17, 2023 •
edited
Loading

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Hide switches with no state labels, same behavior as before the introduction of short labels. No more blank lines with → .

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@groverlynn groverlynn force-pushed the switch_skip branch 5 times, most recently from 801a762 to f091a63 Compare July 17, 2023 02:10
@groverlynn groverlynn changed the title Skip switches with no state labels Skip switches without state labels Nov 4, 2023
@groverlynn groverlynn mentioned this pull request Apr 26, 2024
Closed
@lotem lotem closed this in ce77835 Apr 27, 2024
@groverlynn groverlynn deleted the switch_skip branch April 29, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@groverlynn