feat(storage): add support composite sort key in MergeIterator #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BaymaxHWY <854541526@qq.com>
skyzh
approved these changes
Apr 12, 2022
| // TODO: handle can-not-compare | ||
| res = left_data.partial_cmp(&right_data).unwrap(); | ||
| if Ordering::Equal != res { | ||
| break; |
There was a problem hiding this comment.
just return res here? so that res can simply be a local variable
| for sort_key_idx in &self.sort_key_idx { | ||
| let left_data = self.chunk_buffer[*left_id] | ||
| .as_ref() | ||
| .unwrap() |
There was a problem hiding this comment.
can we move this unwrap to the outer loop, so that we can do less conditional branch?
skyzh
changed the title
Signed-off-by: BaymaxHWY <854541526@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: BaymaxHWY 854541526@qq.com
close issue: #588