fix: make header correct when using group by #624
Conversation
src/binder/expression/mod.rs
Outdated
| @@ -133,6 +133,26 @@ impl BoundExpr { | |||
| visitor.visit_expr(self); | |||
| visitor.0 | |||
| } | |||
|
|
|||
| pub fn format_name(&self, child_schema: &Vec<ColumnDesc>) -> String { | |||
| println!("{:?}", self); | |||
There was a problem hiding this comment.
Please don't print extra things to the screen. Also, would you please add unit tests for this function?
| self.group_keys | ||
| .iter() | ||
| .for_each(|expr| expr.resolve_input_ref(&mut input_refs)); | ||
| self.group_keys.iter().for_each(|expr| { |
There was a problem hiding this comment.
I don't think we need to have input_refs vec here. Just map group_keys to ColumnDesc, and chain it with agg_call is enough.
There was a problem hiding this comment.
The resolve_input_ref is useful in somewhere else, but not here 🤣 I forgot why we wrote such thing here.
|
btw, you'll need to sign DCO 🤣 |
shmiwy
changed the title
it seems that something terrible when I press this command(Lots of commits come up)🤣🤣🤣🤣 |
|
I've rebase updated for you :) You might need to git fetch && git reset --hard origin/bug_fix to make your local branch up-to-date with this remote one. |
| .enumerate() | ||
| .map(|(index, expr)| { | ||
| ColumnDesc::new( | ||
| child_schema[index].datatype().clone(), |
There was a problem hiding this comment.
still doesn't seem correct? we should use expression's return type instead of child schema's type.
| @@ -133,6 +133,25 @@ impl BoundExpr { | |||
| visitor.visit_expr(self); | |||
| visitor.0 | |||
| } | |||
|
|
|||
| pub fn format_name(&self, child_schema: &Vec<ColumnDesc>) -> String { | |||
There was a problem hiding this comment.
Please add unit tests for this function :)
* use DataChunkbuilder to refactor ValuesExecutor Signed-off-by: Jayice <1185430411@qq.com> * code format Signed-off-by: Jayice <1185430411@qq.com> * code style Signed-off-by: Jayice <1185430411@qq.com> Signed-off-by: Shmiwy <wyf000219@126.com>
Signed-off-by: Shmiwy <wyf000219@126.com>
Signed-off-by: Shmiwy wyf000219@gamil.com Signed-off-by: Shmiwy <wyf000219@126.com>
Signed-off-by: Shmiwy wyf000219@gamil.com Signed-off-by: Shmiwy <wyf000219@126.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com> Signed-off-by: Shmiwy <wyf000219@126.com>
close #538
Signed-off-by: Shmiwy wyf000219@gamil.com