refactor(planner): use AggInputRefResolver to handle group by expr #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fedomn <fedomn.ma@gmail.com>
skyzh
approved these changes
Apr 18, 2022
| select sum(v1), v2 + 1 as a, count(*) from t group by a | ||
| ---- | ||
| 3 2 2 | ||
| 7 3 2 | ||
| 5 4 1 | ||
|
|
||
| query II rowsort | ||
| query III rowsort |
There was a problem hiding this comment.
We need to verify if provided column number is the same as user input? cc @wangrunji0408
There was a problem hiding this comment.
I believe it should verify. But now the database returns a string, which makes it hard to split user input into columns (
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix part of #539
the original group by expression support (#535) seems not very clear for resolving
InputRef, so I refactor the main logic toInputRefResolver. And fix panic for:but it still leaves some issues:
select v2 + 2 + count(*) from t group by v2 + 1;Signed-off-by: Fedomn fedomn.ma@gmail.com