Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): support multi-line interactive mode #662

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

Gun9niR
Copy link
Contributor

@Gun9niR Gun9niR commented Jun 22, 2022

Signed-off-by: Gun9niR gun9nir.guo@gmail.com

#475

; at the end of a line terminates input for the current statement(s).

Signed-off-by: Gun9niR <gun9nir.guo@gmail.com>
@Gun9niR
Copy link
Contributor Author

Gun9niR commented Jun 22, 2022

@skyzh request review

@wangrunji0408 wangrunji0408 requested a review from skyzh June 22, 2022 14:36
Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@Gun9niR
Copy link
Contributor Author

Gun9niR commented Jun 22, 2022

Whoops, just found a bug, where simply typing enter will change the prompt to ?. Please do not merge this pr now. (fixed)

Signed-off-by: Gun9niR <gun9nir.guo@gmail.com>
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@skyzh skyzh merged commit 9699cba into risinglightdb:main Jun 23, 2022
@Gun9niR Gun9niR deleted the multi-line-cli branch June 23, 2022 12:48
xinchengxx pushed a commit to xinchengxx/risinglight that referenced this pull request Jul 12, 2022
* feat(cli): support multi-line interactive mode

Signed-off-by: Gun9niR <gun9nir.guo@gmail.com>

* fix(cli): avoid changing command prompt when typing empty line

Signed-off-by: Gun9niR <gun9nir.guo@gmail.com>
Signed-off-by: xinchengforgit <2419743144@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants