Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make binary operations auto-vectorized #700

Merged
merged 6 commits into from
Oct 4, 2022
Merged

feat: make binary operations auto-vectorized #700

merged 6 commits into from
Oct 4, 2022

Conversation

lokax
Copy link
Member

@lokax lokax commented Oct 2, 2022

There are null values in the last 64 pieces of every 192 pieces of data.

array mul binary op/65536                                                                            
                        time:   [590.75 µs 592.65 µs 595.27 µs]

array mul function (standard)/65536                                                                            
                        time:   [73.460 µs 73.719 µs 74.018 µs]

array mul function (standard + never inline )/65536                                                                            
                        time:   [177.76 µs 178.30 µs 178.88 µs]

array mul function (lazy select)/65536                                                                             
                        time:   [25.540 µs 25.698 µs 25.869 µs]

array mul function (lazy select + never inline)/65536                                                                            
                        time:   [109.85 µs 110.21 µs 110.70 µs]

array mul simd/65536    time:   [108.47 µs 108.87 µs 109.35 µs]

lokax added 4 commits October 2, 2022 11:49
@lokax
feat: binary executor
1715f5f 
feat: vectorization

Signed-off-by: lokax <m632656684@gmail.com>

feat: vectorization

Signed-off-by: lokax <m632656684@gmail.com>

feat: enable auto-vectorization

Signed-off-by: lokax <m632656684@gmail.com>

feat: improve evaluation performance

Signed-off-by: lokax <m632656684@gmail.com>

chore: benchmark

Signed-off-by: lokax <m632656684@gmail.com>

chore: use usize

Signed-off-by: lokax <m632656684@gmail.com>
@lokax
chore: resovle conflict
1f494f6 
Signed-off-by: lokax <m632656684@gmail.com>
@lokax
fix: into ordered f64
ad3d20e 
Signed-off-by: lokax <m632656684@gmail.com>
@lokax
chore: remove unwrap
a108abf 
Signed-off-by: lokax <m632656684@gmail.com>
@lokax lokax requested a review from skyzh October 2, 2022 09:20
@skyzh skyzh requested review from wangrunji0408 and xxchan October 2, 2022 18:45
@skyzh skyzh enabled auto-merge (squash) October 3, 2022 22:48
@skyzh skyzh disabled auto-merge October 3, 2022 23:59
@skyzh
Copy link
Member

skyzh commented Oct 3, 2022

There are a few commits without sign offs. Could you please fix it? Thanks!

@lokax
feat: add function context
f330e6b 
Signed-off-by: lokax <m632656684@gmail.com>
@skyzh skyzh enabled auto-merge (squash) October 4, 2022 03:32
@skyzh skyzh merged commit f6adfe2 into risinglightdb:main Oct 4, 2022
@wangrunji0408 wangrunji0408 mentioned this pull request Dec 12, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

@wangrunji0408 wangrunji0408 Awaiting requested review from wangrunji0408

@xxchan xxchan Awaiting requested review from xxchan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lokax @skyzh