Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): checksum BlockType in block header #704

Merged
merged 3 commits into from
Oct 10, 2022
Merged

fix(storage): checksum BlockType in block header #704

merged 3 commits into from
Oct 10, 2022

Conversation

unconsolable
Copy link
Member

What's changed:

  • Split the encode of BlockHeader to checksum and non-checksum
  • Take non-checksum part of header (currently BlockType) to checksum calculation
  • Move BlockHeader to the footer of block
  • Change checksum validation logic

close #247

Signed-off-by: unconsolable chenzhipeng2012@gmail.com

@unconsolable
fix(storage): checksum BlockType in block header
ea29fe5 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@skyzh skyzh self-requested a review October 6, 2022 14:26
skyzh
skyzh approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM. If you don't want to resolve the comments for now, ping me for merging and I'll do the rest.

@unconsolable
BlockHeader -> BlockMeta
b8b6b34 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@skyzh skyzh enabled auto-merge (squash) October 10, 2022 02:03
@skyzh skyzh merged commit 4f295a8 into risinglightdb:main Oct 10, 2022
@unconsolable unconsolable deleted the checksum-blocktype branch October 10, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage: checksum BlockType in block header
2 participants
@unconsolable @skyzh