-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(binder): egg binder for drop statement #711
feat(binder): egg binder for drop statement #711
Conversation
Signed-off-by: Elias.Yao <siran0611@gmail.com>
Signed-off-by: Elias.Yao <siran0611@gmail.com>
Signed-off-by: Elias.Yao <siran0611@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM. Thanks!
Signed-off-by: Elias.Yao <siran0611@gmail.com>
Indeed I'm wondering why we're commenting out the original drop and add a new BoundDrop between the expressions. Please hold this PR a little while and I will refactor tonight. |
I thought both ways are acceptable. Given that the drop statement is unlikely to be rewritten by rules, representing it as a single |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some futures plans in my mind:
- Why insert / create / drop are part of
pub enum Expr
? 🤣 Seems a little bit weird but I'm thinking if it is possible to make it more clear. - I believe we only need to support Drop(Id) in RisingLight. We can remove cascade / remove_if_exist later.
Yeah, putting them all into the |
#707