feat(planner_v2): add type checker #717
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a type checker to the new planner. It is implemented as an egg analysis. Each
Expr
node will be associated with a type analysis result, which can be either a type or an error. If a type error is found after constructing a node, the binder will return the error:Note that the type checker in this PR is far from complete. For example, it only allows binary operations on values of the same type (INT + INT ✅), and doesn't support implicit type cast yet (INT + DOUBLE ❌). I've added some failing tests to show these limits. They will be fixed in the future.