fix(storage): compaction type error #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compaction panic in old code: #696 (comment) After fix: |
Signed-off-by: Yue Yin <yueyin.dev@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
skyzh
force-pushed
the
yueyin/fix_compaction
branch
from
e8423de to
37f7993
Compare
skyzh
approved these changes
Dec 12, 2022
MingjiHan99
pushed a commit
that referenced
this pull request
Dec 22, 2022
* Fix compaction type error Signed-off-by: Yue Yin <yueyin.dev@gmail.com> * assert empty Signed-off-by: Alex Chi <iskyzh@gmail.com> Signed-off-by: Yue Yin <yueyin.dev@gmail.com> Signed-off-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: Alex Chi <iskyzh@gmail.com> Signed-off-by: MingjiHan <mjhan@bu.edu>
MingjiHan99
pushed a commit
that referenced
this pull request
Dec 22, 2022
* Fix compaction type error Signed-off-by: Yue Yin <yueyin.dev@gmail.com> * assert empty Signed-off-by: Alex Chi <iskyzh@gmail.com> Signed-off-by: Yue Yin <yueyin.dev@gmail.com> Signed-off-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: Alex Chi <iskyzh@gmail.com> Signed-off-by: MingjiHan <mjhan@bu.edu>
wangrunji0408
added a commit
that referenced
this pull request
Dec 23, 2022
* fix(storage): compaction type error (#737) * Fix compaction type error Signed-off-by: Yue Yin <yueyin.dev@gmail.com> * assert empty Signed-off-by: Alex Chi <iskyzh@gmail.com> Signed-off-by: Yue Yin <yueyin.dev@gmail.com> Signed-off-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: Alex Chi <iskyzh@gmail.com> Signed-off-by: MingjiHan <mjhan@bu.edu> * chore: bump sqllogictest to 0.9.0 (#736) Signed-off-by: MingjiHan <mjhan@bu.edu> * feat(storage): Dict encoding for compaction (#740) * Dict encoding for compaction Signed-off-by: Yue Yin <yueyin.dev@gmail.com> * CI Signed-off-by: Yue Yin <yueyin.dev@gmail.com> * Add tests Signed-off-by: Yue Yin <yueyin.dev@gmail.com> Signed-off-by: Yue Yin <yueyin.dev@gmail.com> Signed-off-by: MingjiHan <mjhan@bu.edu> * perf(expr): apply auto-vectorization and remove explicit SIMDs (#741) * remove explicit simd Signed-off-by: Runji Wang <wangrunji0408@163.com> * apply auto-vectorization for all binary/unary ops Signed-off-by: Runji Wang <wangrunji0408@163.com> * add more bench for ops Signed-off-by: Runji Wang <wangrunji0408@163.com> * SIMD accelerate &[bool] to BitVec Signed-off-by: Runji Wang <wangrunji0408@163.com> * optimize const expression evaluation Signed-off-by: Runji Wang <wangrunji0408@163.com> * fix clippy Signed-off-by: Runji Wang <wangrunji0408@163.com> * recover push Signed-off-by: Runji Wang <wangrunji0408@163.com> Signed-off-by: Runji Wang <wangrunji0408@163.com> Signed-off-by: MingjiHan <mjhan@bu.edu> * release: v0.2 (#742) Signed-off-by: Alex Chi <iskyzh@gmail.com> Signed-off-by: MingjiHan <mjhan@bu.edu> * perf(expr): further optimize performance (#744) * optimize to string array Signed-off-by: Runji Wang <wangrunji0408@163.com> * optimize bitvec Signed-off-by: Runji Wang <wangrunji0408@163.com> * avoid zip_eq for performance Signed-off-by: Runji Wang <wangrunji0408@163.com> * array: add `is_null` and `get_raw` Signed-off-by: Runji Wang <wangrunji0408@163.com> * add bench for array filter Signed-off-by: Runji Wang <wangrunji0408@163.com> * optimize filter -30% Signed-off-by: Runji Wang <wangrunji0408@163.com> * optimize filter from bool array Signed-off-by: Runji Wang <wangrunji0408@163.com> * clear null data Signed-off-by: Runji Wang <wangrunji0408@163.com> * fix cardinality error Signed-off-by: Runji Wang <wangrunji0408@163.com> * remove array iterator Signed-off-by: Runji Wang <wangrunji0408@163.com> * introduce non-null iterator Signed-off-by: Runji Wang <wangrunji0408@163.com> * optimize bitmap && Signed-off-by: Runji Wang <wangrunji0408@163.com> * optimize BitVec operations Signed-off-by: Runji Wang <wangrunji0408@163.com> * fix clippy and test Signed-off-by: Runji Wang <wangrunji0408@163.com> Signed-off-by: Runji Wang <wangrunji0408@163.com> Signed-off-by: MingjiHan <mjhan@bu.edu> * add path option (#747) Signed-off-by: MingjiHan <mjhan@bu.edu> Signed-off-by: MingjiHan <mjhan@bu.edu> * wtf Signed-off-by: MingjiHan <mjhan@bu.edu> * updates Signed-off-by: Mingji Han <mjhan@bu.edu> Signed-off-by: MingjiHan <mjhan@bu.edu> * change python compile configurations Signed-off-by: Mingji Han <mjhan@bu.edu> Signed-off-by: MingjiHan <mjhan@bu.edu> * updates Signed-off-by: Mingji Han <mjhan@bu.edu> Signed-off-by: MingjiHan <mjhan@bu.edu> * change python compile configurations Signed-off-by: Mingji Han <mjhan@bu.edu> Signed-off-by: MingjiHan <mjhan@bu.edu> * add python type conversion Signed-off-by: Mingji Han <mjhan@bu.edu> Signed-off-by: MingjiHan <mjhan@bu.edu> * add docs Signed-off-by: Mingji Han <mjhan@bu.edu> Signed-off-by: MingjiHan <mjhan@bu.edu> * fix format Signed-off-by: Mingji Han <mjhan@bu.edu> Signed-off-by: MingjiHan <mjhan@bu.edu> * fix macos Signed-off-by: MingjiHan <mjhan@bu.edu> * fix linux... Signed-off-by: MingjiHan <mjhan@bu.edu> * support macOS complication Signed-off-by: MingjiHan <mjhan@bu.edu> * Update docs/07-python-extension.md Co-authored-by: Runji Wang <wangrunji0408@163.com> Signed-off-by: MingjiHan <mjhan@bu.edu> * Update docs/07-python-extension.md Co-authored-by: Runji Wang <wangrunji0408@163.com> Signed-off-by: MingjiHan <mjhan@bu.edu> * Update src/lib.rs Co-authored-by: Runji Wang <wangrunji0408@163.com> Signed-off-by: MingjiHan <mjhan@bu.edu> * Update src/lib.rs Co-authored-by: Runji Wang <wangrunji0408@163.com> Signed-off-by: MingjiHan <mjhan@bu.edu> * move files Signed-off-by: MingjiHan <mjhan@bu.edu> Signed-off-by: Yue Yin <yueyin.dev@gmail.com> Signed-off-by: Alex Chi <iskyzh@gmail.com> Signed-off-by: MingjiHan <mjhan@bu.edu> Signed-off-by: Runji Wang <wangrunji0408@163.com> Signed-off-by: Mingji Han <mjhan@bu.edu> Co-authored-by: Yue Yin <41224888+yinfredyue@users.noreply.github.com> Co-authored-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: xxchan <xxchan22f@gmail.com> Co-authored-by: Runji Wang <wangrunji0408@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #696
Signed-off-by: Yue Yin yueyin.dev@gmail.com