Modernize ruby #27
Open
Modernize ruby #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I went through vim-ruby's syntax/ruby.vim and renamed or removed syntax names
that had been changed there.
I also renamed vim-detailed original names to avoid implying that the syntax
came from vim-ruby, such as {-ruby-}{+detailed+}Initialize.
Finally, I removed highlight links that already existed in vim-ruby.
For somewhat arbitrary reasons it seems that rubyBlockParameter was removed from vim-ruby's syntax/ruby.vim. Re-add it so that we have something to link the new rubyNumberedBlockParam to, and also because I vaguely remember having it and it was nice. Also introduce rubyNumberedBlockParamError to help Rubyists avoid using `_0` by mistake. vim-ruby/vim-ruby@074200f vim-ruby/vim-ruby@eba5233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through vim-ruby's syntax/ruby.vim and renamed or removed syntax names
that had been changed there.
I also renamed vim-detailed original names to avoid implying that the syntax
came from vim-ruby, such as {-ruby-}{+detailed+}Initialize.
Finally, I removed highlight links that already existed in vim-ruby.
For somewhat arbitrary reasons it seems that rubyBlockParameter was removed from
vim-ruby's syntax/ruby.vim. Re-add it so that we have something to link the new
rubyNumberedBlockParam to, and also because I vaguely remember having it and it
was nice.
Also introduce rubyNumberedBlockParamError to help Rubyists avoid using
_0bymistake.