[maxswerve/swerveutils] Fix sign bug #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sciencewhiz : is this something you can look into? |
auscompgeek
reviewed
Feb 22, 2025
epanov1602
force-pushed
the
ep/swerveutils-bug-fix
branch
from
3d0314d to
970ef62
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in how sign of
(target - current)is calculated. Add test.(likely this was an oversight when this code was converted from Java)
We noticed because encountered weird behavior with MaxSwerve Python example when joystick is suddenly released back to zero. Reproducing in simulation gave us this.