-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clean up cometbft tutorial to remove outdate DA references #511
Conversation
WalkthroughThe changes involve modifications to the guide on converting a CometBFT app into a Rollkit app. Key updates include simplifying section headers, particularly the initialization instructions, and removing references to Local Data Availability. The command for starting the Rollkit app has been adjusted to use placeholders for user-defined flags. A new concluding sentence encourages users to explore additional tutorial sections, enhancing the guide's clarity and comprehensiveness. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
guides/cometbft-to-rollkit.md (2)
29-33
: Consider adding a reference to DA configuration optionsWhile removing the specific Local DA reference improves maintainability, it might be helpful to add a brief note directing users to the DA configuration documentation mentioned in the summary section.
Consider adding:
To prepare your app for Rollkit, you'll need to initialize it. + +For information about configuring different Data Availability options, please refer to the DA configuration section in the tutorials.
62-63
: Enhance the concluding section with linksThe reference to additional tutorials would be more useful with direct links.
Consider updating to:
-To learn more about how to config your DA, Sequencing, and Execution, please check out those tutorial sections. +To learn more about configuring your rollup, check out our tutorials on: +- [Data Availability Configuration](../tutorials/da-config.md) +- [Sequencing Configuration](../tutorials/sequencing.md) +- [Execution Configuration](../tutorials/execution.md)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
guides/cometbft-to-rollkit.md
(2 hunks)
🔇 Additional comments (1)
guides/cometbft-to-rollkit.md (1)
63-63
: Verify the existence of referenced tutorial sections
Let's ensure all referenced tutorial sections exist before adding the links.
✅ Verification successful
Add links to the referenced tutorial sections
All the referenced tutorial sections exist in the tutorials/
directory:
- tutorials/da-config.md
- tutorials/sequencing.md
- tutorials/execution.md
Consider adding hyperlinks to these sections to improve navigation.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if the referenced tutorial sections exist
echo "Checking for tutorial files..."
for section in "da-config" "sequencing" "execution"; do
if fd -t f "${section}.md" tutorials/; then
echo "✓ Found ${section}.md"
else
echo "✗ Missing ${section}.md"
fi
done
Length of output: 514
Overview
Summary by CodeRabbit