Feature/jruby support #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Removed some commented out tests + Moved tests requiring downloading to format specific files + Updated gemspec and Gemfiles
Also did some minor test refactoring
`test_finalize` broke in ruby 2.4 because of changes in Ruby's GC. The initial fix was to fork the process to make sure directories where being cleaned properly. Unfortunately, this caused a segfault when running the entire test suite. The issue was related to where `ObjectSpace.define_finalizer` was being called from (a class that was being extended by a module). The issue is probably related to Nokogiri, but I wasn't able to develop a trivial example of the error. Creating the finalizer in the class fixed the issue in Ruby 2.4.0.
Updated travis JRuby
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Jan 8, 2017
## [2.7.1] 2017-01-03 ### Fixed - Fixed regression where a CSV's encoding was being ignored [372](roo-rb/roo#372) ## [2.7.0] 2016-12-31 ### Fixed - Added rack server for testing Roo's download capabilities [365](roo-rb/roo#365) - Refactored tests into different formats [365](roo-rb/roo#365) - Fixed OpenOffice for JRuby [362](roo-rb/roo#362) - Added '0.000000' => '%.6f' number format [354](roo-rb/roo#354) - Add additional formula cell types for to_csv [367][roo-rb/roo#367] ### Added - Extracted formatters from Roo::Base#to_* methods [364](roo-rb/roo#364) ## [2.6.0] 2016-12-28 ### Fixed - Fixed error if sheet name starts with a slash [348](roo-rb/roo#348) - Fixed loading to support files on ftp [355](roo-rb/roo#355) - Fixed Ruby 2.4.0 deprecation warnings [356](roo-rb/roo#356) - properly return date as string [359](roo-rb/roo#359) ### Added - Cell values can be set in a CSV [350](roo-rb/roo#350) - Raise an error Roo::Excelx::Extractor document is missing [358](roo-rb/roo#358)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.