lints

.lintr

@@ -1,4 +1,5 @@
 linters: linters_with_defaults(
+  cyclocomp_linter = NULL,
   infix_spaces_linter = NULL,
   object_length_linter = NULL,
   object_name_linter = NULL,

DESCRIPTION

@@ -12,7 +12,7 @@ Description: Pipeline tools coordinate the pieces of computationally
   The methodology in this package
   borrows from GNU 'Make' (2015, ISBN:978-9881443519)
   and 'drake' (2018, <doi:10.21105/joss.00550>).
-Version: 1.10.0.9001
+Version: 1.10.0.9002
 License: MIT + file LICENSE
 URL: https://docs.ropensci.org/targets/, https://github.com/ropensci/targets
 BugReports: https://github.com/ropensci/targets/issues

NEWS.md

@@ -1,6 +1,7 @@
-# targets 1.10.0.9001 (development)
+# targets 1.10.0.9002 (development)
 
 * Restore explicit references to "self" in `R6` classes.
+* Perform `crew` task retries.
 
 # targets 1.10.0
 

R/class_crew.R

@@ -230,6 +230,15 @@ crew_class <- R6::R6Class(
       if (is.null(result)) {
         return()
       }
+      if (result$status == "crash") {
+        target <- pipeline_get_target(self$pipeline, result$name)
+        self$scheduler$reporter$report_retry(
+          target = target,
+          progress = self$scheduler$progress
+        )
+        self$run_target(target)
+        return()
+      }
       tar_assert_all_na(
         result$error,
         msg = paste("target", result$name, "error:", result$error)

R/class_reporter.R

@@ -73,6 +73,8 @@ reporter_class <- R6::R6Class(
     },
     report_workspace = function(target) {
     },
+    report_retry = function(target = NULL, progress = NULL) {
+    },
     report_finalize = function(progress = NULL) {
     },
     flush_messages = function() {

R/class_summary.R

@@ -43,6 +43,9 @@ summary_class <- R6::R6Class(
     report_canceled = function(target = NULL, progress) {
       self$report_progress(progress)
     },
+    report_retry = function(target = NULL, progress) {
+      self$report_progress(progress)
+    },
     report_finalize = function(progress) {
       self$report_progress(progress)
       self$flush_messages()

R/class_timestamp.R

@@ -80,6 +80,16 @@ timestamp_class <- R6::R6Class(
         )
       )
     },
+    report_retry = function(target, progress = NULL) {
+      self$buffer_message(
+        cli_retry(
+          target_get_name(target),
+          target_get_type_cli(target),
+          time_stamp = TRUE,
+          print = FALSE
+        )
+      )
+    },
     report_end = function(progress = NULL, seconds_elapsed = NULL) {
       self$flush_messages()
       progress$cli_end(time_stamp = TRUE, seconds_elapsed = seconds_elapsed)

R/class_verbose.R

@@ -69,6 +69,15 @@ verbose_class <- R6::R6Class(
     report_workspace = function(target) {
       self$buffer_message(cli_workspace(target_get_name(target), print = FALSE))
     },
+    report_retry = function(target, progress = NULL) {
+      self$buffer_message(
+        cli_retry(
+          target_get_name(target),
+          target_get_type_cli(target),
+          print = FALSE
+        )
+      )
+    },
     report_finalize = function(progress = NULL) {
       self$flush_messages()
     },

R/utils_cli.R

@@ -126,6 +126,12 @@ cli_workspace <- function(name, time_stamp = FALSE, print = TRUE) {
   cli_blue_play(msg, print = print)
 }
 
+cli_retry <- function(name, prefix = NULL, time_stamp = FALSE, print = TRUE) {
+  time <- if_any(time_stamp, time_stamp_cli(), NULL)
+  msg <- paste(c(time, "retrying", prefix, name), collapse = " ")
+  cli_magenta_play(msg, print = print)
+}
+
 cli_blue_bullet <- function(msg, print = TRUE) {
   symbol <- cli_symbol_bullet_blue
   msg <- paste(symbol, msg)
@@ -138,6 +144,12 @@ cli_blue_play <- function(msg, print = TRUE) {
   if_any(print, message(msg), msg)
 }
 
+cli_magenta_play <- function(msg, print = TRUE) {
+  symbol <- cli_symbol_play_magenta
+  msg <- paste(symbol, msg)
+  if_any(print, message(msg), msg)
+}
+
 cli_green_record <- function(msg, print = TRUE) {
   symbol <- cli_symbol_record_green
   msg <- paste(symbol, msg)
@@ -241,6 +253,7 @@ cli_url <- function(url) {
 
 cli_symbol_bullet_blue <- cli::col_blue(cli::symbol$bullet)
 cli_symbol_play_blue <- cli::col_blue(cli::symbol$play)
+cli_symbol_play_magenta <- cli::col_magenta(cli::symbol$play)
 cli_symbol_record_green <- cli::col_green(cli::symbol$record)
 cli_symbol_box_yellow <- cli::col_yellow(cli::symbol$stop)
 cli_symbol_info_cyan <- cli::col_cyan(cli::symbol$info)

tests/interactive/test-crew_retries.R

@@ -0,0 +1,33 @@
+test_that("crew retries", {
+  tar_script({
+    tar_option_set(controller = crew::crew_controller_local())
+    tar_target(x, {
+      Sys.sleep(15)
+      "completed despite retries"
+    })
+  })
+  # Run each of the following interactively.
+  # Terminate the crew worker (open htop, search "crew::crew_worker")
+  # and observe the retries.
+  tar_destroy()
+  tar_make(reporter = "silent")
+  expect_equal(tar_read(x), "completed despite retries")
+  tar_destroy()
+  tar_make(reporter = "verbose")
+  expect_equal(tar_read(x), "completed despite retries")
+  tar_destroy()
+  tar_make(reporter = "verbose_positives")
+  expect_equal(tar_read(x), "completed despite retries")
+  tar_destroy()
+  tar_make(reporter = "timestamp")
+  expect_equal(tar_read(x), "completed despite retries")
+  tar_destroy()
+  tar_make(reporter = "timestamp_positives")
+  expect_equal(tar_read(x), "completed despite retries")
+  tar_destroy()
+  tar_make(reporter = "summary")
+  expect_equal(tar_read(x), "completed despite retries")
+  tar_destroy()
+  tar_make(reporter = "verbose") # Max out the retry quota on this last one.
+  tar_destroy()
+})