Use pre-commit fork of clang-format instead of local #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anfemosa,
aprotyas,
destogl,
livanov93,
LukasMacha97 and
VanshGehlot
|
What exactly wasn't working - I'm curious? |
aprotyas
approved these changes
Nov 1, 2023
|
This doesn't require a certain version of clang-format to be installed
locally. Good if you want to use a different version locally but also helps
people who don't have the same setup to "just call pre-commit" for
formatting
…On Wed, 1 Nov 2023, 19:26 Abrar Rahman Protyasha, ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#813 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA24PYLSER2TCGO7R5OXZDDYCKO5NAVCNFSM6AAAAAA6ZYL66KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMBYHA4DGMZSGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #813 +/- ##
=======================================
Coverage 45.29% 45.29%
=======================================
Files 40 40
Lines 3663 3663
Branches 1730 1730
=======================================
Hits 1659 1659
Misses 821 821
Partials 1183 1183
Flags with carried forward coverage won't be shown. Click here to find out more. |
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Nov 19, 2023
Squashed commit of the following: commit 0a9f4b0 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Nov 16 23:17:20 2023 +0000 Bump ros-tooling/action-ros-ci from 0.3.4 to 0.3.5 (ros-controls#833) commit 3fc0f50 Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Wed Nov 15 20:03:40 2023 +0100 [JTC] Activate update of dynamic parameters (ros-controls#761) commit b13ae5b Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Wed Nov 15 19:14:09 2023 +0100 [JTC] Fix tests when state offset is used (ros-controls#797) * Simplify initialization of states * Rename read_state_from_hardware method * Don't set state_desired in on_activate --------- Co-authored-by: Dr. Denis <denis@stoglrobotics.de> commit f1a5397 Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Wed Nov 15 12:18:38 2023 +0100 [JTC] Remove deprecation warnings, set `allow_nonzero_velocity_at_trajectory_end` default false (ros-controls#834) commit 232154d Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Sat Nov 11 15:30:19 2023 +0100 [CI] Update coverage workflows and some cleanup (ros-controls#819) * Add CI coverage jobs for humble and iron * Add all packages to source build * Update repos files * Build ros-control packages from source * use humble job names Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> --------- Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> commit 0196eeb Author: Tony Baltovski <tony.baltovski@gmail.com> Date: Thu Nov 9 17:15:45 2023 -0500 [diff_drive_controller] Fixed typos in diff_drive_controller_parameter.yaml. (ros-controls#822) commit 71ec842 Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Tue Nov 7 13:47:23 2023 +0100 [CI] Re-add humble workflow files and add iron to readme (ros-controls#818) commit 9d4ea6b Author: Bence Magyar <bence.magyar.robotics@gmail.com> Date: Tue Nov 7 12:01:23 2023 +0000 [diff_drive_controller] Remove non-stamped Twist option (ros-controls#812) commit 5f78fe4 Author: Bence Magyar <bence.magyar.robotics@gmail.com> Date: Tue Nov 7 12:01:02 2023 +0000 Adjust tests after passing URDF to controllers (ros-controls#817) commit 2c6d7a6 Author: Bence Magyar <bence.magyar.robotics@gmail.com> Date: Mon Nov 6 18:29:10 2023 +0000 Add iron branch (ros-controls#814) commit f81a82c Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Fri Nov 3 21:18:31 2023 +0100 [CI] Codecov (ros-controls#807) commit c6ecab7 Author: Bence Magyar <bence.magyar.robotics@gmail.com> Date: Wed Nov 1 21:38:16 2023 +0000 Use pre-commit fork of clang-format instead of local (ros-controls#813) commit 6e46053 Author: Bence Magyar <bence.magyar.robotics@gmail.com> Date: Tue Oct 31 21:34:10 2023 +0000 3.17.0 commit 822552f Author: Bence Magyar <bence.magyar.robotics@gmail.com> Date: Tue Oct 31 21:33:40 2023 +0000 Update changelogs commit 8a90b51 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Oct 31 20:27:04 2023 +0000 Bump ros-tooling/action-ros-ci from 0.3.3 to 0.3.4 (ros-controls#810) commit b65314d Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Thu Oct 26 12:09:27 2023 +0200 Cleanup comments and unnecessary checks (ros-controls#803) commit b36b9d2 Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Tue Oct 24 20:17:28 2023 +0200 [CI] Fix coverage build and codecov stats (ros-controls#804) commit 22356e0 Author: Dr. Denis <denis@stoglrobotics.de> Date: Mon Oct 16 18:49:47 2023 +0200 [TestNodes] Optimize output about setup of JTC publisher (ros-controls#792) commit ac291ab Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Mon Oct 16 13:00:53 2023 +0200 Steering controllers library: fix open loop mode (ros-controls#793) * set last*velocity variables for open loop odometry * Make function arguments const * Update function in header file too commit c831b6c Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Date: Mon Oct 16 12:58:44 2023 +0200 Update requirements of state interfaces (ros-controls#798)
henrygerardmoore
pushed a commit
to henrygerardmoore/ros2_controllers
that referenced
this pull request
Jul 19, 2024
* add rqt_controller_manager Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * port rqt_controller_manager package.xml from ros1 Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * add controller_manager_utils package Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * copy utils.py from ros1 Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * override utils.py with one from rqt_joint_trajectory_controlle Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * updates for ros2 Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * got controllers loading and unloading Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * fix up state transition Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * don't skip copyright check Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * fill maintainer tag Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * got loading controller names from parameters somewhat working Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * rename get_rosparam_controller_names to get_parameter_controller_names Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * change logic to use node names rather than namespaces Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * allow activation of controller from rqt_controller_manager Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * fix up imports Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * use services from controller_manager_services instead of setting up service clients Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * clean up cm_name Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * clean up, change "stop" to "deactivate" Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * remove controller_manager_utils, and port necessary functionality into controller_manager.py Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * fix format and copyright to pass tests Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * change license of rqt_controller_manager Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * update plugin.xml Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * remove redundant dependency Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * stretch last section in rqt_controller_manager table Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * update docstring Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * Update rqt_controller_manager/rqt_controller_manager/update_combo.py Co-authored-by: Erick G. Islas-Osuna <erickisos653@gmail.com> * Apply suggestions from code review Co-authored-by: Erick G. Islas-Osuna <erickisos653@gmail.com> * Updated to work on rolling. * Fixup formatting. * Update maintainers in rqt_controller_manager/package.xml Co-authored-by: Denis Štogl <denis@stoglrobotics.de> * update maintainers, and remove ijnek Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> * remove tests, since they're covered in CI Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com> Co-authored-by: Erick G. Islas-Osuna <erickisos653@gmail.com> Co-authored-by: Denis Štogl <denis@stoglrobotics.de> Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
10/10 would use it again