Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove catkin-specific naming from directories and variables #577

Closed
wants to merge 17 commits into from

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Oct 20, 2018

With more and more changes coming in I think it makes sense to plan for integrating the colcon branch from #548 into the default branch with a configuration option to choose the build tool. While that might require some effort the longer the separation stays as is we will continue to have to port patches between the two main branches.

This patch is a precursor of that to minimize the changes:

  • The first commit removes catkin-specific naming of directories as well as (environment) variables.
  • The second commit passes the make flags via the environment instead of as a command line argument.
  • The third commit moves the workspace functions into a module without catkin in the name.
  • The fourth commit creates a call_build_tool function with a different API than call_catkin_make_isolated to allow switching the build tool by parameter.
  • The fifth commit renames the catkin_make_isolated_and_* scripts.
  • The sixth commit updates the code to use the renamed scripts and makes them use the new call_build_tool function.
  • The seventh commit updates the call_build_tool function to support invoking colcon.
  • The eighth commit adds the configuration option build_tool to source and doc build files and passes the information through the numerous layers.

@dirk-thomas dirk-thomas self-assigned this Oct 20, 2018
@dirk-thomas dirk-thomas force-pushed the remove_catkin_specific_naming branch 9 times, most recently from f94bf44 to 9ccae51 Compare October 23, 2018 00:00
@dirk-thomas dirk-thomas force-pushed the remove_catkin_specific_naming branch 2 times, most recently from 82454ca to 37594d1 Compare October 23, 2018 01:58
@dirk-thomas dirk-thomas force-pushed the remove_catkin_specific_naming branch 4 times, most recently from b726837 to dcfe8ea Compare October 23, 2018 18:48
@dirk-thomas dirk-thomas force-pushed the remove_catkin_specific_naming branch from dcfe8ea to d9f9e9a Compare October 23, 2018 19:47
@dirk-thomas dirk-thomas mentioned this pull request Oct 23, 2018
9 tasks
@dirk-thomas dirk-thomas force-pushed the remove_catkin_specific_naming branch 3 times, most recently from 88fa381 to 87e51cb Compare October 24, 2018 04:42
@dirk-thomas dirk-thomas force-pushed the remove_catkin_specific_naming branch from 87e51cb to 8fea00b Compare October 24, 2018 04:57
@dirk-thomas dirk-thomas force-pushed the remove_catkin_specific_naming branch from ecf272f to 7bc5e16 Compare October 24, 2018 05:57
@dirk-thomas
Copy link
Member Author

Closing in favor of #585.

@dirk-thomas dirk-thomas deleted the remove_catkin_specific_naming branch October 24, 2018 16:59
k-okada added a commit to k-okada/jog_control that referenced this pull request Aug 20, 2019
7675t added a commit to tork-a/jog_control that referenced this pull request Aug 20, 2019
k-okada added a commit to k-okada/pr2_common that referenced this pull request Aug 30, 2019
k-okada added a commit to k-okada/pr2_common that referenced this pull request Aug 30, 2019
…ONFIG_URL_BRANCH to speciy old config file for EoL distros
v4hn pushed a commit to PR2/pr2_common that referenced this pull request Aug 30, 2019
…ONFIG_URL_BRANCH to speciy old config file for EoL distros (#279)
k-okada added a commit to k-okada/pr2_apps that referenced this pull request Sep 11, 2019
…ONFIG_URL_BRANCH to speciy old config file for EoL distros
k-okada added a commit to PR2/pr2_apps that referenced this pull request Sep 11, 2019
fix workspace name due to ros-infrastructure/ros_buildfarm#577, set CONFIG_URL_BRANCH to speciy old config file for EoL distros
k-okada added a commit to k-okada/pr2_navigation that referenced this pull request Nov 14, 2019
k-okada added a commit to k-okada/pr2_navigation that referenced this pull request Nov 14, 2019
k-okada added a commit to k-okada/shared_autonomy_manipulation that referenced this pull request Nov 26, 2019
k-okada added a commit to k-okada/executive_smach_visualization that referenced this pull request Dec 11, 2019
k-okada added a commit to ros-visualization/executive_smach_visualization that referenced this pull request Dec 11, 2019
k-okada added a commit to k-okada/app_manager that referenced this pull request Dec 12, 2019
k-okada added a commit to k-okada/app_manager that referenced this pull request Dec 12, 2019
k-okada added a commit to PR2/app_manager that referenced this pull request Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant