-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove catkin-specific naming from directories and variables #577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f94bf44
to
9ccae51
Compare
…ove duplicate code
82454ca
to
37594d1
Compare
b726837
to
dcfe8ea
Compare
dcfe8ea
to
d9f9e9a
Compare
88fa381
to
87e51cb
Compare
87e51cb
to
8fea00b
Compare
ecf272f
to
7bc5e16
Compare
Merged
Closing in favor of #585. |
k-okada
added a commit
to k-okada/jog_control
that referenced
this pull request
Aug 20, 2019
7675t
added a commit
to tork-a/jog_control
that referenced
this pull request
Aug 20, 2019
fix workspace name due to ros-infrastructure/ros_buildfarm#577
k-okada
added a commit
to k-okada/pr2_common
that referenced
this pull request
Aug 30, 2019
k-okada
added a commit
to k-okada/pr2_common
that referenced
this pull request
Aug 30, 2019
…ONFIG_URL_BRANCH to speciy old config file for EoL distros
v4hn
pushed a commit
to PR2/pr2_common
that referenced
this pull request
Aug 30, 2019
…ONFIG_URL_BRANCH to speciy old config file for EoL distros (#279)
k-okada
added a commit
to k-okada/pr2_apps
that referenced
this pull request
Sep 11, 2019
…ONFIG_URL_BRANCH to speciy old config file for EoL distros
k-okada
added a commit
to PR2/pr2_apps
that referenced
this pull request
Sep 11, 2019
fix workspace name due to ros-infrastructure/ros_buildfarm#577, set CONFIG_URL_BRANCH to speciy old config file for EoL distros
k-okada
added a commit
to k-okada/pr2_navigation
that referenced
this pull request
Nov 14, 2019
k-okada
added a commit
to k-okada/pr2_navigation
that referenced
this pull request
Nov 14, 2019
k-okada
added a commit
to k-okada/shared_autonomy_manipulation
that referenced
this pull request
Nov 26, 2019
k-okada
added a commit
to k-okada/executive_smach_visualization
that referenced
this pull request
Dec 11, 2019
k-okada
added a commit
to ros-visualization/executive_smach_visualization
that referenced
this pull request
Dec 11, 2019
fix workspace name due to ros-infrastructure/ros_buildfarm#577
k-okada
added a commit
to k-okada/app_manager
that referenced
this pull request
Dec 12, 2019
k-okada
added a commit
to k-okada/app_manager
that referenced
this pull request
Dec 12, 2019
k-okada
added a commit
to PR2/app_manager
that referenced
this pull request
Dec 12, 2019
fix workspace name due to ros-infrastructure/ros_buildfarm#577
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With more and more changes coming in I think it makes sense to plan for integrating the
colcon
branch from #548 into the default branch with a configuration option to choose the build tool. While that might require some effort the longer the separation stays as is we will continue to have to port patches between the two main branches.This patch is a precursor of that to minimize the changes:
catkin
in the name.call_build_tool
function with a different API thancall_catkin_make_isolated
to allow switching the build tool by parameter.catkin_make_isolated_and_*
scripts.call_build_tool
function.call_build_tool
function to support invokingcolcon
.build_tool
to source and doc build files and passes the information through the numerous layers.