-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internationalize the docs upload and canonical url #184
Conversation
Since EOL distros aren't being regenerated why update those entries? I assume the old URLs will be redirected to the new layout anyway (and maybe existing canonical URLs replaced with the new)? |
I updated them all because if they're not deleted they are presumably being kept to be potentially turned on again by us in the future or by someone else. This will make it consistent and able to be turned back on. If we don't want to maintain them we should probably just remove them entirely. There will be redirects for all the legacy urls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Shouldn't be merged until the server operation has been performed.
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/migration-of-docs-ros-org-content-into-en-prefix/16829/1 |
Move completed, and backwards compatibility symlinks are installed. |
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/migration-of-docs-ros-org-content-into-en-prefix/16829/2 |
They successfully reconfigured overnight:
And successfully uploaded with the new directory structure and canonical url generated: http://build.ros.org/view/Kdoc/job/Kdoc__geometry2__ubuntu_xenial_amd64/3 |
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-10-15/16849/1 |
* internationalize the docs upload and canonical url * missed canonical links
This must be merged in conjunction with the server crossover