Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internationalize the docs upload and canonical url #184

Merged
merged 2 commits into from
Oct 15, 2020

Conversation

tfoote
Copy link
Member

@tfoote tfoote commented Oct 14, 2020

This must be merged in conjunction with the server crossover

@tfoote tfoote self-assigned this Oct 14, 2020
@dirk-thomas
Copy link
Member

Since EOL distros aren't being regenerated why update those entries? I assume the old URLs will be redirected to the new layout anyway (and maybe existing canonical URLs replaced with the new)?

@tfoote
Copy link
Member Author

tfoote commented Oct 14, 2020

I updated them all because if they're not deleted they are presumably being kept to be potentially turned on again by us in the future or by someone else. This will make it consistent and able to be turned back on. If we don't want to maintain them we should probably just remove them entirely.

There will be redirects for all the legacy urls.

Copy link

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Shouldn't be merged until the server operation has been performed.

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/migration-of-docs-ros-org-content-into-en-prefix/16829/1

@tfoote tfoote marked this pull request as ready for review October 15, 2020 19:00
@tfoote
Copy link
Member Author

tfoote commented Oct 15, 2020

Move completed, and backwards compatibility symlinks are installed.

@tfoote tfoote merged commit 9dc4d02 into production Oct 15, 2020
@tfoote tfoote deleted the internationalize_docs branch October 15, 2020 19:01
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/migration-of-docs-ros-org-content-into-en-prefix/16829/2

@tfoote
Copy link
Member Author

tfoote commented Oct 16, 2020

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-10-15/16849/1

nuclearsandwich referenced this pull request in ros2/ros_buildfarm_config Dec 28, 2020
* internationalize the docs upload and canonical url

* missed canonical links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants