Temporarily use windows-2019

[christophebedard]

See #712 (comment)

Signed-off-by: Christophe Bedard bedard.christophe@gmail.com

[codecov]

Codecov Report

Merging #719 (346cfbc) into master (ee483a7) will increase coverage by 1.14%.
The diff coverage is n/a.

❗ Current head 346cfbc differs from pull request most recent head aca7518. Consider uploading reports for the commit aca7518 to get more accurate results

@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
+ Coverage   48.47%   49.61%   +1.14%     
==========================================
  Files           2        2              
  Lines         262      262              
  Branches       68       68              
==========================================
+ Hits          127      130       +3     
+ Misses        135      132       -3     

Impacted Files	Coverage Δ
src/action-ros-ci.ts	43.34% <0.00%> (+1.28%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee483a7...aca7518. Read the comment docs.

[christophebedard]

@wmmc88 do you know why the Windows jobs are failing?

[wmmc88]

@wmmc88 do you know why the Windows jobs are failing?

It looks like an issue with setup-ros. I looked into it a bit this morning and it looked like pip in setup-ros was failing to install the requested dependencies.

It's odd that it's not printing what error it encountered tho. It might be related to the github runners now having pip version 22 which seems to have changed console prints to be done thru rich.

[wmmc88]

@christophebedard

looks like theres several upstream issues revolving around pip and the latest windows images on github. could be related:
actions/runner-images#5027
actions/toolkit#992
mesonbuild/meson#9955 (comment)
pypa/pip#10444

[christophebedard]

We could temporarily pin pip to 21.3.1 as suggested here: actions/runner-images#5027 (comment)

[wmmc88]

We could temporarily pin pip to 21.3.1 as suggested here: actions/virtual-environments#5027 (comment)

yup, sounds like most people are pinning pip as the workaround. seen it being used in many repos w/ github actions rn.

[christophebedard]

I did it separately in #467, just because we will probably revert them separarely. well nevermind, it's a different repo 🤦‍♂️ ros-tooling/setup-ros#467

[christophebedard]

I think this should be good now that ros-tooling/setup-ros#467 has been merged and released.

@wmmc88 requesting a trivial review approval 😁

[wmmc88]

Lgtm!