Custom error handler #375
Merged
Custom error handler #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks ok to me. The default behavior shouldn't change and the other part has been tested against capabilities. |
|
+1 |
| @@ -540,7 +540,7 @@ class ServiceImpl(_Service): | |||
| Implementation of ROS Service. This intermediary class allows for more configuration of behavior than the Service class. | |||
| """ | |||
|
|
|||
| def __init__(self, name, service_class, handler, buff_size=DEFAULT_BUFF_SIZE): | |||
| def __init__(self, name, service_class, handler, buff_size=DEFAULT_BUFF_SIZE, error_handler=None): | |||
There was a problem hiding this comment.
Since the new argument is anything but trivial it should get a description in the doc block. Or at least mention which other constructor it relates to (since it is documented there).
There was a problem hiding this comment.
He has some doc stuff in the Service class, I think this is slim on docs because it is the Impl class.
|
Please address the one remaining comment and finally squash your commits. |
|
@dirk-thomas done! |
dirk-thomas
added a commit
that referenced
this pull request
Mar 18, 2014
dirk-thomas
added a commit
that referenced
this pull request
Mar 20, 2014
|
Cherry-picked to hydro-devel. |
dirk-thomas
added a commit
that referenced
this pull request
Mar 21, 2014
dirk-thomas
added a commit
that referenced
this pull request
Mar 21, 2014
rsinnet
pushed a commit
to MisoRobotics/ros_comm
that referenced
this pull request
Jun 19, 2017
Custom error handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch allows users to define a custom behavior for handling exceptions raised from within a service.