Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fixes #9

Merged
merged 4 commits into from
Dec 8, 2024
Merged

CI fixes #9

merged 4 commits into from
Dec 8, 2024

Conversation

9names
Copy link
Member

@9names 9names commented Dec 8, 2024

Disable needless_lifetimes needed to ignore this warning:

error: the following explicit lifetimes could be elided: 'a
   --> src/inner/generic.rs:209:6
    |
209 | impl<'a, REG, const WI: u8, FI, Safety> FieldWriter<'a, REG, WI, FI, Safety>
    |      ^^                                             ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `-D clippy::needless-lifetimes` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
    |
209 - impl<'a, REG, const WI: u8, FI, Safety> FieldWriter<'a, REG, WI, FI, Safety>
209 + impl<REG, const WI: u8, FI, Safety> FieldWriter<'_, REG, WI, FI, Safety>
    |

error: could not compile `rp235x-pac` (lib) due to 1 previous error
Error: Process completed with exit code 101.

Locked version of svd2rust is needed to avoid an issue with proc-macro2:

[WARN  svd2rust::generate::register] Missing description for register RESET
thread 'main' panicked at /home/nine/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.92/src/lib.rs:849:13:
unsupported proc macro punctuation character '{'

Need to indent a multiline string in YAML to fix this:

+ svdtools patch svd/RP2350.yaml
[2024-12-08T07:35:35Z ERROR svdtools::cli] by svdtools (0.3.20)
    
    Caused by:
        invalid indentation in quoted scalar at byte 96 line 7 column 22

Need to update svdtools to 0.3.20 to get a new version of time to avoid this error:

error[E0282]: type annotations needed for `Box<_>`
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.31/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
   = note: this is an inference error on crate `time` caused by an API change in Rust 1.80.0; update `time` to version `>=0.3.35` by calling `cargo update`

In the YAML spec, it is required to indent any multiline string.
The library used by svdtools is now more strict, and will throw
"invalid indentation in quoted scalar"
errors without this change.
@9names 9names mentioned this pull request Dec 8, 2024
@9names 9names added this pull request to the merge queue Dec 8, 2024
Merged via the queue into rp-rs:main with commit 9404cf4 Dec 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants