Issue with some non-associative arith operators

[andrewmarx]

Starting with commit 957aa40, it appears that the behavior of at least two non-associative operators has changed and now are producing the same results regardless of the order of the inputs:

library(terra)

r <- rast(matrix(0.5, 3, 3))

values(2 - r)
values(r - 2)

values(r / 2)
values(2 / r)

The output:

> values(2 - r)
      lyr.1
 [1,]  -1.5
 [2,]  -1.5
 [3,]  -1.5
 [4,]  -1.5
 [5,]  -1.5
 [6,]  -1.5
 [7,]  -1.5
 [8,]  -1.5
 [9,]  -1.5
> values(r - 2)
      lyr.1
 [1,]  -1.5
 [2,]  -1.5
 [3,]  -1.5
 [4,]  -1.5
 [5,]  -1.5
 [6,]  -1.5
 [7,]  -1.5
 [8,]  -1.5
 [9,]  -1.5
> values(r / 2)
      lyr.1
 [1,]  0.25
 [2,]  0.25
 [3,]  0.25
 [4,]  0.25
 [5,]  0.25
 [6,]  0.25
 [7,]  0.25
 [8,]  0.25
 [9,]  0.25
> values(2 / r)
      lyr.1
 [1,]  0.25
 [2,]  0.25
 [3,]  0.25
 [4,]  0.25
 [5,]  0.25
 [6,]  0.25
 [7,]  0.25
 [8,]  0.25
 [9,]  0.25

I don't know if this is isolated to just these two operators

[rhijmans]

Ouch. That's terrible. I believe order has been restored and I will send this to CRAN over the weekend. Thanks very much for reporting.

> values(2 - r)
      lyr.1
 [1,]   1.5
 [2,]   1.5
 [3,]   1.5
 [4,]   1.5
 [5,]   1.5
 [6,]   1.5
 [7,]   1.5
 [8,]   1.5
 [9,]   1.5
> values(r - 2)
      lyr.1
 [1,]  -1.5
 [2,]  -1.5
 [3,]  -1.5
 [4,]  -1.5
 [5,]  -1.5
 [6,]  -1.5
 [7,]  -1.5
 [8,]  -1.5
 [9,]  -1.5
> 
> values(r / 2)
      lyr.1
 [1,]  0.25
 [2,]  0.25
 [3,]  0.25
 [4,]  0.25
 [5,]  0.25
 [6,]  0.25
 [7,]  0.25
 [8,]  0.25
 [9,]  0.25
> values(2 / r)
      lyr.1
 [1,]     4
 [2,]     4
 [3,]     4
 [4,]     4
 [5,]     4
 [6,]     4
 [7,]     4
 [8,]     4
 [9,]     4