Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds some more variables to arxive template #356

Merged
merged 6 commits into from
Dec 16, 2020
Merged

Adds some more variables to arxive template #356

merged 6 commits into from
Dec 16, 2020

Conversation

eliocamp
Copy link
Contributor

@eliocamp eliocamp commented Dec 15, 2020 •
edited
Loading

Related to #345
The arxive template didn't have the holy

$for(header-includes)$
$header-includes$
$endfor$

it also had biblyographystyle hardcoded.

@eliocamp eliocamp changed the title Adds header-includes to arxive template Adds some customisations to arxive template Dec 15, 2020
yihui
yihui approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It might be worth mentioning in a NEWS bullet. Thanks!

@cderv Feel free to merge after you review it. @slemonide will need to adjust #345 accordingly.

cderv
cderv requested changes Dec 16, 2020
View reviewed changes
Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about renaming the variable below. After that it is ready to merge.

Thanks!

@cderv cderv mentioned this pull request Dec 16, 2020
Closed
@eliocamp eliocamp mentioned this pull request Dec 16, 2020
Merged
@cderv cderv changed the title Adds some customisations to arxive template Adds some more variables to arxive template Dec 16, 2020
@cderv cderv merged commit 37bfb52 into rstudio:master Dec 16, 2020
@cderv
Copy link
Collaborator

cderv commented Dec 16, 2020

Thanks @eliocamp !

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cderv cderv cderv requested changes

@yihui yihui yihui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eliocamp @cderv @yihui