-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theme.json file and remove few theme support from php file #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Just a note, I believe hybrid themes require the CSS on FE to be added manually using the tokens generated by the theme.json file. Please verify it once before letting it through. |
@robicse11127 Please verify this, update the |
|
Verified this or you're yet to do it? |
@RahiDroid |
@robicse11127 The Could you please include some examples demonstrating those in the If you want, you can refer Twenty-TwentyThree theme's theme.json file. |
@RahiDroid Got it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes, almost there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @robicse11127 and @devanshijoshi9! 🚀
Description
Checklist
Fixes/Covers issue
Fixes #80
Note- Keep few of the theme support in php as I am unable to find theme support in theme.json file. Here is the reference.