tokyo12: proxy_set_header Host $http_host #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osyoyu
commented
Aug 3, 2024
| location ~ ^/tokyo12(.*) { | ||
| location /tokyo12 { |
There was a problem hiding this comment.
ついでに無駄に (?) regex だったのをやめた
|
@sorah r? |
sorah
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #110.
https://regional.rubykaigi.org/tokyo12/が 200 になる一方、https://regional.rubykaigi.org/tokyo12(trailing slash なし) がhttps://osyoyu.github.io/tokyo12/への 302 になってしまうのを解消したいパッチです。osyoyu.github.ioはなるべく露出させたくない。osyoyu.github.ioになる（GitHub Pages は regional.rubykaigi.org からプロキシされていることを当然知らないから）そこで……
regional.rubykaigi.orgを設定したCNAMEファイルを置くやつregional.rubykaigi.orgでホストされている前提の挙動になるregional.rubykaigi.orgになる/tokyo12から/になる)ということなのですが、アクセス時に期待される Host ヘッダも
regional.rubykaigi.orgになるわけです。そこで proxy_set_header を指定する必要がある、という内容のパッチでした。