Add snake case aliases for escapeURIComponent #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsbt
force-pushed
the
uri-component-aliases
branch
from
d81c246 to
4a10a0f
Compare
hsbt
force-pushed
the
uri-component-aliases
branch
from
4a10a0f to
4ec8290
Compare
hsbt
force-pushed
the
uri-component-aliases
branch
from
4ec8290 to
a60754b
Compare
|
@casperisfine Sorry to late response. Can you skip tests or implement for JRuby and TruffleRuby? |
casperisfine
force-pushed
the
uri-component-aliases
branch
2 times, most recently
from
04498c7 to
65b6bf7
Compare
As agreed in [Feature #18822]
casperisfine
force-pushed
the
uri-component-aliases
branch
from
65b6bf7 to
11c11ef
Compare
|
@hsbt done! |
|
Thanks always! |
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As agreed in [Feature #18822]
cc @nobu