Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the log level for the fork interception #394

Closed
ccdredzik opened this issue Nov 16, 2021 · 4 comments
Closed

Change the log level for the fork interception #394

ccdredzik opened this issue Nov 16, 2021 · 4 comments

Comments

@ccdredzik
Copy link

ccdredzik commented Nov 16, 2021

Your proposal

Stop logging it as WARN, start logging it as TRACE or DEBUG.

Additional context

It obscures normal execution.

@st0012
Copy link
Member

st0012 commented Nov 30, 2021

If you're talking about these messages: "Detaching after fork ...." and "Attaching after process ...", I think they can be downgraded to debug in the future. But at the moment, the forking mechanism isn't completely stable and can cause issues like #336. Having this message can help users be aware of process forking and identify/report the problem.

@ko1
Copy link
Collaborator

ko1 commented Dec 2, 2021

Does it hurts your test or your favorite?

@JunichiIto
Copy link
Contributor

When I run RSpec against Rails 7 application, I see this warning. It's noisy a little to read the result of tests.

$ bundle exec rspec -f progress
...................................................................DEBUGGER: Attaching after process 69034 fork to child process 69055
...

Finished in 3.26 seconds (files took 1.79 seconds to load)
70 examples, 0 failures

In addition, this warning is displayed in red when I run tests within RubyMine's terminal. I sometimes misunderstand that something is wrong with my application.

Screen Shot 2021-12-31 at 10 10 05

I'd be glad if it is suppressed by default.

@ko1
Copy link
Collaborator

ko1 commented Dec 2, 2022

#823 makes it INFO level.

@ko1 ko1 closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants