Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 Reduce breakpoint activation logging from warn to info #750

Closed
wants to merge 1 commit into from
Closed

🔊 Reduce breakpoint activation logging from warn to info #750

wants to merge 1 commit into from

Conversation

marianosimone
Copy link
Contributor

Similar to #394, these logs are a bit noisy and not that useful for the average user:

DEBUGGER:  BP - Line  /<redacted>.rb:<line> (call) is activated.

Reducing to info makes it less noisy.

@ko1
Copy link
Collaborator

ko1 commented Sep 16, 2022

b Foo#bar can be issued when the Foo#bar is not defined.
When Foo#bar is defined, the breakpoint is enabled.
This message is printed when the breakpoint is enabled.

The purpose of this message is BP is activated correctly.
For example, typo like b Foo#baz (typo of bar) doesn't show the activation message and you can know the typo.

I think average users need this messages.

I agree it should be info and I think default loglevel should be info.
Advanced users like you can set loglevel as a warn.

@marianosimone
Copy link
Contributor Author

Closing in favor of #752

@marianosimone marianosimone deleted the reduce_log_level branch September 16, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants