Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change for JRuby #69

Closed
Brockfrancom opened this issue Dec 4, 2024 · 2 comments
Closed

Breaking change for JRuby #69

Brockfrancom opened this issue Dec 4, 2024 · 2 comments

Comments

@Brockfrancom
Copy link

Version 0.5.0 causes a bundle update to fail. https://github.com/ruby/resolv/pull/57/files is the change I suspect broke it.

When the following snippet is ran in a rails console on a Mac, an error is thrown as shown below:

jruby-9.4.6.0 :001 > require 'mkmf'
 => true 
jruby-9.4.6.0 :002 > have_library('iphlpapi', 'GetNetworkParams')
checking for GetNetworkParams() in -liphlpapi... /Users/brock/.rvm/rubies/jruby-9.4.6.0/lib/ruby/stdlib/mkmf.rb:456:in `try_do': The compiler failed to generate an executable file. (RuntimeError)
You have to install development tools first.

I think 'iphlpapi' is a windows library that doesn't exist on Mac.

@hsbt
Copy link
Member

hsbt commented Dec 10, 2024

I could install resolv-0.5.0.

$ gem i resolv
Successfully installed resolv-0.5.0
1 gem installed

It seems JRuby specific issue, not macOS.

@hsbt hsbt closed this as completed Dec 10, 2024
@hsbt hsbt reopened this Dec 10, 2024
@hsbt
Copy link
Member

hsbt commented Dec 10, 2024

Building native extensions. This could take a while...
ERROR:  Error installing resolv:
        ERROR: Failed to build gem native extension.

    current directory: /Users/hsbt/.local/share/gem/gems/resolv-0.5.0/ext/win32/resolv
/Users/hsbt/.local/share/rbenv/versions/jruby-9.4.9.0/bin/jruby -I /Users/hsbt/.local/share/rbenv/versions/jruby-9.4.9.0/lib/ruby/stdlib extconf.rb
checking for GetNetworkParams() in -liphlpapi... *** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.

@hsbt hsbt changed the title Breaking change for Mac users Breaking change for JRuby Dec 10, 2024
nobu added a commit that referenced this issue Dec 10, 2024
Instead of checking for the existence of the necessary function.  On
JRuby no C compiler is available and this call results in a runtime
error.
nobu added a commit that referenced this issue Dec 10, 2024
Instead of checking for the existence of the necessary function.  On
JRuby no C compiler is available and this call results in a runtime
error.
nobu added a commit that referenced this issue Dec 10, 2024
Instead of checking for the existence of the necessary function.  On
JRuby no C compiler is available and this call results in a runtime
error.
nobu added a commit that referenced this issue Dec 10, 2024
On JRuby no C compiler is available and this call results in a runtime
error.
nobu added a commit that referenced this issue Dec 10, 2024
On JRuby no C compiler is available and this call results in a runtime
error.
nobu added a commit that referenced this issue Dec 10, 2024
On JRuby no C compiler is available and this call results in a runtime
error.
nobu added a commit that referenced this issue Dec 10, 2024
On JRuby no C compiler is available and this call results in a runtime
error.
nobu added a commit that referenced this issue Dec 10, 2024
On JRuby no C compiler is available and this call results in a runtime
error.
@nobu nobu closed this as completed in 33105bc Dec 10, 2024
matzbot pushed a commit to ruby/ruby that referenced this issue Dec 10, 2024
ruby/resolv#69)

On JRuby no C compiler is available and this call results in a runtime
error.

ruby/resolv@33105bc504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants