Allow setting default Resolv::DNS config in Resolv.new #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorah
reviewed
Feb 29, 2024
|
My recommendation would be to warn for the |
|
sounds good for me |
If a positional argument is provided, the use_ipv6 keyword option is ignored: ```ruby Resolv.new([Resolv::DNS.new], use_ipv6: false) ``` Issue a warning in this case. Currently, you have to pass a positional hash argument to set the DNS config. However, after support for the use_ipv6 keyword argument is removed, you will be able to pass either a positional hash or keyword arguments. Code that was just specifying the use_ipv6 keyword optional will still work correctly in that case.
jeremyevans
force-pushed
the
resolv-new-set-config
branch
from
ccaf072 to
5ff9dda
Compare
|
@sorah OK, I made that change. |
|
@sorah Do you think we can merge this so this change makes it into Ruby 3.4? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just passing the use_ipv6 option, pass all options given. By using a singular hash argument instead of keywords, this avoids the issue when a user does:
Which would have resulted in the use_ipv6 option being ignored.
This is backwards compatible, because there has not yet been a release with the use_ipv6 keyword supported.
Prompted by #14 (comment)