Issue 7 #9
Merged
Issue 7 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I made it read the md and use some regex to find things in between certain characters or character pairs and to then wrap them in the appropriate html tags. Particularly italics and bold.
Actually comparing the source code with this might be strange given that I had to move around the directory structure as per our conversation. It's going to look like everything is new but only a few things have changed. The bulk of what I wrote is just going to be under the one function "createHtml".
If the file extension is .md then I have some regex_replace to rewrite the md tokens with html tags.